Skip to content

Commit 08ab7ab

Browse files
re-use live mode config - and improve docs on how to start liveMode (#1003)
* Use config.liveMode to turn on liveMode in the timer * Discussion of `startLive(1500)` was incorrect as startLive is based on timestamps, not playback offsets. Also reorder to introduce `addEvent` earlier Co-authored-by: Eoghan Murray <[email protected]>
1 parent bac1d7b commit 08ab7ab

File tree

3 files changed

+28
-13
lines changed

3 files changed

+28
-13
lines changed

docs/recipes/live-mode.md

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,28 @@ If you want to replay the events in a real-time way, you can use the live mode A
55
When you are using rrweb's Replayer to do a real-time replay, you need to configure `liveMode: true` and call the `startLive` API to enable the live mode.
66

77
```js
8-
const replayer = new rrweb.Replayer([], {
8+
const ANY_OLD_EVENTS = [];
9+
const replayer = new rrweb.Replayer(ANY_OLD_EVENTS, {
910
liveMode: true,
1011
});
11-
12-
replayer.startLive(FIRST_EVENT.timestamp - BUFFER);
12+
replayer.startLive();
1313
```
1414

15-
When calling the `startLive` API, there is an optional parameter to set the baseline time. This is quite useful when you live scenario needs a buffer time.
16-
17-
For example, you have an event recorded at timestamp 1500. Calling `startLive(1500)` will set the baseline time to 1500 and all the timing calculation will be based on this.
15+
Later when you receive new events (e.g. over websockets), you can add them using:
1816

19-
But this may cause your replay to look laggy. Because data transportation needs time(such as the delay of the network). And some events have been throttled(such as mouse movements) which has a delay by default.
17+
```
18+
function onReceive(event) {
19+
replayer.addEvent(event);
20+
}
21+
```
2022

21-
So we can configure a smaller baseline time to the `startLive` API, like `startLive(500)`. This will let the replay always delay 1 second than the source. If the time of data transportation is not longer than 1 second, the user will not feel laggy.
23+
When calling the `startLive` API, there is an optional parameter to set the baseline time. By default, this is `Date.now()` so that events are applied as soon as they come in, however this may cause your replay to look laggy. Because data transportation needs time(such as the delay of the network). And some events have been throttled(such as mouse movements) which has a delay by default.
2224

23-
When live mode is on, we can call `addEvent` API to add the latest events into the replayer:
25+
Here is how you introduce a buffer:
2426

2527
```js
26-
replayer.addEvent(NEW_EVENT);
28+
const BUFFER_MS = 1000;
29+
replayer.startLive(Date.now() - BUFFER_MS);
2730
```
31+
32+
This will let the replay always delay 1 second than the source. If the time of data transportation is not longer than 1 second, the user will not feel laggy.

packages/rrweb/src/replay/index.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,10 @@ export class Replayer {
262262
this.mirror.reset();
263263
});
264264

265-
const timer = new Timer([], config?.speed || defaultConfig.speed);
265+
const timer = new Timer([], {
266+
speed: this.config.speed,
267+
liveMode: this.config.liveMode,
268+
});
266269
this.service = createPlayerService(
267270
{
268271
events: events

packages/rrweb/src/replay/timer.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,16 @@ export class Timer {
1313
private raf: number | null = null;
1414
private liveMode: boolean;
1515

16-
constructor(actions: actionWithDelay[] = [], speed: number) {
16+
constructor(
17+
actions: actionWithDelay[] = [],
18+
config: {
19+
speed: number;
20+
liveMode: boolean;
21+
},
22+
) {
1723
this.actions = actions;
18-
this.speed = speed;
24+
this.speed = config.speed;
25+
this.liveMode = config.liveMode;
1926
}
2027
/**
2128
* Add an action after the timer starts.

0 commit comments

Comments
 (0)