Skip to content

prototype here does not refer to the correct WebGLRenderingContext … #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2022
Merged

prototype here does not refer to the correct WebGLRenderingContext … #1013

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6125a44
`prototype` here does not refer to the correct WebGLRenderingContext …
eoghanmurray Sep 30, 2022
9b41eb8
Update packages/rrweb/test/integration.test.ts
eoghanmurray Oct 3, 2022
c2c5644
Update packages/rrweb/test/html/canvas-webgl-shader.html
eoghanmurray Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update packages/rrweb/test/html/canvas-webgl-shader.html 
Co-authored-by: Justin Halsall <[email protected]>
  • Loading branch information
@eoghanmurray @Juice10
eoghanmurray and Juice10 authored Oct 3, 2022
commit c2c5644e3d7062e11fb166a272167825a0d2507a
5 changes: 4 additions & 1 deletion packages/rrweb/test/html/canvas-webgl-shader.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,11 @@
gl.drawArrays(gl.TRIANGLES, 0, 3);
}
setTimeout(() => {
// canvas element that never gets appended to the DOM
const confound = document.createElement('canvas');
createTriangle(confound); // this should not be emitted (but was triggering a bug in the emitted canvas)
// These will not be emitted (but was triggering a bug in the emitted canvas)
// @see https://github.com/rrweb-io/rrweb/pull/1013
createTriangle(confound);
const c = document.getElementById('myCanvas');
createTriangle(c);
}, 10);
Expand Down