harmonize on a single getWindowScroll #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… document was scrolling was on `window.pageYOffset`, so we hadn't been able to replay scrolling
Juice10
approved these changes
Nov 21, 2022
Member
|
Duplicate of #881 ? |
help you fix typescript error
help you fix typescript error
YunFeng0817
approved these changes
Jan 9, 2023
This was referenced Jul 6, 2023
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jun 12, 2025
This is the last local diff I had after rrweb-io#1054 was merged
eoghanmurray
added a commit
to statcounter/rrweb
that referenced
this pull request
Sep 18, 2025
This is the last local diff I had after rrweb-io#1054 was merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where only indication I could see in any attribute that the document was scrolling was on
window.pageYOffset, so we hadn't been able to replay scrolling