Skip to content

Perf: Avoid creation of intermediary array when iterating over style rules #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Perf: Avoid creation of intermediary array when iterating over style rules #1272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ac581b
Perf: Avoid creation of intermediary array when iterating over styles…
eoghanmurray Aug 1, 2023
c8e04e9
Create nervous-mirrors-perform.md
eoghanmurray Aug 14, 2023
9c4c5fe
Apply formatting changes
eoghanmurray Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Perf: Avoid creation of intermediary array when iterating over styles… 
…heet rules by using the second `mapFn` argument of Array.from

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from
  • Loading branch information
@eoghanmurray
eoghanmurray committed Aug 14, 2023
commit 6ac581ba454f7e414bf090ce78ea19db50ee26ad
2 changes: 1 addition & 1 deletion packages/rrweb-snapshot/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export function stringifyStylesheet(s: CSSStyleSheet): string | null {
const rules = s.rules || s.cssRules;
return rules
? fixBrowserCompatibilityIssuesInCSS(
Array.from(rules).map(stringifyRule).join(''),
Array.from(rules, stringifyRule).join(''),
)
: null;
} catch (error) {
Expand Down
11 changes: 4 additions & 7 deletions packages/rrweb/src/record/stylesheet-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,12 @@ export class StylesheetManager {
let styleId;
if (!this.styleMirror.has(sheet)) {
styleId = this.styleMirror.add(sheet);
const rules = Array.from(sheet.rules || CSSRule);
styles.push({
styleId,
rules: rules.map((r, index) => {
return {
rule: stringifyRule(r),
index,
};
}),
rules: Array.from(sheet.rules || CSSRule, (r, index) => ({
rule: stringifyRule(r),
index,
})),
});
} else styleId = this.styleMirror.getId(sheet);
adoptedStyleSheetData.styleIds.push(styleId);
Expand Down