Skip to content

Fix performance of splitCssText #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jan 10, 2025
Merged

Fix performance of splitCssText #1615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a065eaf
Fix bug where the right split point was not being picked for the 3rd …
eoghanmurray Dec 18, 2024
e2fe660
Add test to put splitCssText through it's paces with a large file
eoghanmurray Dec 17, 2024
2f663d4
Introduce a limit which causes the 'efficiently' test to fail
eoghanmurray Dec 18, 2024
8ba3b54
Fix that it wasn't able to find a split when both halves were identical
eoghanmurray Dec 17, 2024
61e8b5f
Fix poor 'crawling' performance in this part of the algorithm for lar…
eoghanmurray Dec 17, 2024
3474cb2
Need to take larger jumps to be efficient; use the scaling factor to …
eoghanmurray Dec 17, 2024
906dd3b
Add changeset
eoghanmurray Dec 18, 2024
e0fb33d
Presuming the match on a character is more eficient than the indexOf …
eoghanmurray Dec 18, 2024
f5fcfa5
Fix eslint
eoghanmurray Dec 18, 2024
a797e96
Update puppeteer to try to solve the following issue in github actions:
eoghanmurray Dec 19, 2024
defd363
Bump Chrome to see if it solves following issue in github actions:
eoghanmurray Dec 19, 2024
ad42cba
Both Firefox and the 131 version of Chrome I've upgraded to remove de…
eoghanmurray Dec 20, 2024
dec4ad5
Drop chrome down again as getting overwhelmed with issues so will see…
eoghanmurray Dec 20, 2024
7d1e100
Bump all puppeteer to match the LTS version of chrome we've just spec…
eoghanmurray Dec 20, 2024
0c809e1
Fix json error
eoghanmurray Dec 20, 2024
2bae508
The previous version combo didn't install, trying next one up
eoghanmurray Dec 20, 2024
c43d695
Still getting 'zygote_host_impl_linux.cc(128)] No usable sandbox!' so…
eoghanmurray Dec 22, 2024
e16e2ac
Keep searching through https://github.com/puppeteer/puppeteer/blob/5d…
eoghanmurray Dec 22, 2024
c0bf8f8
Following https://chromium.googlesource.com/chromium/src/+/main/docs/…
eoghanmurray Dec 22, 2024
417a831
Continuing with https://chromium.googlesource.com/chromium/src/+/main…
eoghanmurray Dec 22, 2024
a72a28e
Another bump to find minimum version to remove the 'No Usable Sandbox…
eoghanmurray Dec 30, 2024
a677fb6
Final bump to top of https://github.com/puppeteer/puppeteer/blob/5d72…
eoghanmurray Dec 30, 2024
9086b94
Further bump of Chrome as issue still isn't solved - this previously …
eoghanmurray Dec 30, 2024
724a27b
Revert all puppeteer and chrome related changes as the problem was fi…
eoghanmurray Jan 2, 2025
0fbf355
I keep accidentally forgetting camelCase
eoghanmurray Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Still getting 'zygote_host_impl_linux.cc(128)] No usable sandbox!' so… 
… iterating through versions
  • Loading branch information
@eoghanmurray
eoghanmurray committed Jan 10, 2025
commit c43d695cff31c2cb9ca35558a01da5fe91a5bbad
2 changes: 1 addition & 1 deletion .puppeteerrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ const { join } = require('path');
module.exports = {
// Changes the cache location for Puppeteer.
cacheDirectory: join(__dirname, '.cache', 'puppeteer'),
browserRevision: '127.0.6533.88',
browserRevision: '128.0.6613.119',
};
2 changes: 1 addition & 1 deletion packages/all/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"package.json"
],
"devDependencies": {
"puppeteer": "^23.0.0",
"puppeteer": "^23.3.0",
"vite": "^5.3.1",
"vite-plugin-dts": "^3.9.1",
"vitest": "^1.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/rrweb-plugin-console-record/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"vite": "^5.3.1",
"vite-plugin-dts": "^3.9.1",
"vitest": "^1.4.0",
"puppeteer": "^23.0.0"
"puppeteer": "^23.3.0"
},
"peerDependencies": {
"rrweb": "^2.0.0-alpha.18"
Expand Down
2 changes: 1 addition & 1 deletion packages/record/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"package.json"
],
"devDependencies": {
"puppeteer": "^23.0.0",
"puppeteer": "^23.3.0",
"vite": "^5.3.1",
"vite-plugin-dts": "^3.9.1",
"vitest": "^1.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/replay/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"package.json"
],
"devDependencies": {
"puppeteer": "^23.0.0",
"puppeteer": "^23.3.0",
"vite": "^5.3.1",
"vite-plugin-dts": "^3.9.1",
"vitest": "^1.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/rrdom-nodejs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@typescript-eslint/parser": "^5.23.0",
"compare-versions": "^4.1.3",
"eslint": "^8.15.0",
"puppeteer": "^23.0.0",
"puppeteer": "^23.3.0",
"vite": "^5.3.1",
"vite-plugin-dts": "^3.9.1",
"vitest": "^1.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/rrdom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@typescript-eslint/eslint-plugin": "^5.23.0",
"@typescript-eslint/parser": "^5.23.0",
"eslint": "^8.15.0",
"puppeteer": "^23.0.0",
"puppeteer": "^23.3.0",
"typescript": "^5.4.5",
"vite": "^5.3.1",
"vite-plugin-dts": "^3.9.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/rrweb-snapshot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"@types/jsdom": "^20.0.0",
"@types/node": "^18.15.11",
"@types/puppeteer": "^5.4.4",
"puppeteer": "^23.0.0",
"puppeteer": "^23.3.0",
"ts-node": "^7.0.1",
"tslib": "^1.9.3",
"typescript": "^5.4.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/rrweb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"ignore-styles": "^5.0.1",
"inquirer": "^9.0.0",
"jest-image-snapshot": "^6.2.0",
"puppeteer": "^23.0.0",
"puppeteer": "^23.3.0",
"simple-peer-light": "^9.10.0",
"ts-node": "^10.9.1",
"tslib": "^2.3.1",
Expand Down