Skip to content

bugfix: Sort attributes to make rr_* attributes handled last #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2022
Merged

bugfix: Sort attributes to make rr_* attributes handled last #970

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad24bfd
Sort attributes to make `rr_*` attributes handled last
Juice10 Aug 22, 2022
a5e998e
Update packages/rrweb-snapshot/src/rebuild.ts
Juice10 Aug 24, 2022
d067a97
Merge branch 'master' of https://github.com/rrweb-io/rrweb into attri…
Juice10 Sep 17, 2022
4ecf3b9
Refactor handling of rr_* attributes
Juice10 Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/rrweb-snapshot/src/rebuild.ts
  • Loading branch information
@Juice10
Juice10 authored Aug 24, 2022
commit a5e998ee4aefa626422bc3c18de33a70a3cf466b
2 changes: 1 addition & 1 deletion packages/rrweb-snapshot/src/rebuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export function createCache(): BuildCache {
* `rr_` attributes are magic, they change some of the other attributes on the elements,
* so we need to parse them last so they can overwrite any conflicting attributes.
*
* @param attributes list of html attributes to be added to the element
* @param attributes - list of html attributes to be added to the element
* @returns attributes with rr_* attributes last in the array
*/
function sortAttributes(attributes: attributes): attributes {
Expand Down