Skip to content

Fix a bug that Stream parser doesn't expand the user-defined entity references for "text" #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 5 commits into from
Aug 21, 2024
Merged

Fix a bug that Stream parser doesn't expand the user-defined entity references for "text" #200

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68939ea
Add a test case to unnormalize the predefined entities of "text" in t…
naitoh Aug 19, 2024
8b97bae
Fix a bug that Stream parser doesn't expand the user-defined entity r…
naitoh Aug 19, 2024
dc48407
Add support for XML entity expansion limitation in Stream parser
naitoh Aug 19, 2024
7a8f3e3
Update test_with_only_default_entities test case
naitoh Aug 19, 2024
c636358
Changed the XML description of the test code to `here document` format.
naitoh Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test_with_only_default_entities test case 
## Why?
Because `StreamParser#entity_expansion_count` was added.
  • Loading branch information
@naitoh
naitoh committed Aug 20, 2024
commit 7a8f3e3059f42c66d76837d54bbf4804b15778f0
4 changes: 3 additions & 1 deletion test/test_stream.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,12 @@ def text(text)
end
end
listener.text_value = ""
REXML::Document.parse_stream(source, listener)
parser = REXML::Parsers::StreamParser.new( source, listener )
parser.parse

expected_value = "<p>#{'A' * @default_entity_expansion_text_limit}</p>"
assert_equal(expected_value, listener.text_value.strip)
assert_equal(0, parser.entity_expansion_count)
assert do
listener.text_value.bytesize > @default_entity_expansion_text_limit
end
Expand Down