Almost done, still a slight problem with HGETALL.

Author: nicolasff

library.c

@@ -294,16 +294,16 @@ PHPAPI void redis_long_response(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_s
 
 PHPAPI int redis_sock_read_multibulk_reply_zipped(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock, zval *z_tab TSRMLS_DC) {
 
-	int ret = redis_sock_read_multibulk_reply(INTERNAL_FUNCTION_PARAM_PASSTHRU, redis_sock, NULL TSRMLS_CC);
-	array_zip_values_and_scores(INTERNAL_FUNCTION_PARAM_PASSTHRU, 1);
+	int ret = redis_sock_read_multibulk_reply(INTERNAL_FUNCTION_PARAM_PASSTHRU, redis_sock, z_tab TSRMLS_CC);
+	array_zip_values_and_scores(return_value, 1);
 
 	return ret;
 }
 
 PHPAPI int redis_sock_read_multibulk_reply_zipped_strings(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock, zval *z_tab TSRMLS_DC) {
 
-	int ret = redis_sock_read_multibulk_reply(INTERNAL_FUNCTION_PARAM_PASSTHRU, redis_sock, NULL TSRMLS_CC);
-	array_zip_values_and_scores(INTERNAL_FUNCTION_PARAM_PASSTHRU, 0);
+	int ret = redis_sock_read_multibulk_reply(INTERNAL_FUNCTION_PARAM_PASSTHRU, redis_sock, z_tab TSRMLS_CC);
+	array_zip_values_and_scores(return_value, 0);
 
 	return ret;
 }

php_redis.h

@@ -133,7 +133,7 @@ PHPAPI void generic_sort_cmd(INTERNAL_FUNCTION_PARAMETERS, char *sort, int use_a
 PHPAPI void generic_empty_cmd(INTERNAL_FUNCTION_PARAMETERS, char *cmd, int cmd_len TSRMLS_DC, ...);
 PHPAPI void generic_empty_long_cmd(INTERNAL_FUNCTION_PARAMETERS, char *cmd, int cmd_len TSRMLS_DC, ...);
 
-PHPAPI void array_zip_values_and_scores(INTERNAL_FUNCTION_PARAMETERS, int use_atof TSRMLS_DC);
+PHPAPI void array_zip_values_and_scores(zval *z_tab, int use_atof TSRMLS_DC);
 PHPAPI int redis_response_enqueued(RedisSock *redis_sock TSRMLS_DC);
 
 PHPAPI int get_flag(zval *object);

redis.c

@@ -3589,14 +3589,13 @@ PHP_METHOD(Redis, hGetAll) {
 	REDIS_PROCESS_RESPONSE(redis_sock_read_multibulk_reply_zipped_strings);
 }
 
-PHPAPI void array_zip_values_and_scores(INTERNAL_FUNCTION_PARAMETERS, int use_atof TSRMLS_DC) {
+PHPAPI void array_zip_values_and_scores(zval *z_tab, int use_atof TSRMLS_DC) {
 
     zval *z_ret;
     MAKE_STD_ZVAL(z_ret);
-    *z_ret = *return_value; /* copy */
-    array_init(return_value);
+    array_init(z_ret);
 
-    HashTable *keytable = Z_ARRVAL_P(z_ret);
+    HashTable *keytable = Z_ARRVAL_P(z_tab);
 	int i = 0;
     for(zend_hash_internal_pointer_reset(keytable);
         zend_hash_has_more_elements(keytable) == SUCCESS;
@@ -3631,12 +3630,16 @@ PHPAPI void array_zip_values_and_scores(INTERNAL_FUNCTION_PARAMETERS, int use_at
         hval_len = Z_STRLEN_PP(z_value_pp);
 
         if(use_atof) {
-            add_assoc_double_ex(return_value, hkey, 1+hkey_len, atof(hval));
+            add_assoc_double_ex(z_ret, hkey, 1+hkey_len, atof(hval));
         } else {
-            add_assoc_stringl_ex(return_value, hkey, 1+hkey_len, hval, hval_len, 1);
+            add_assoc_stringl_ex(z_ret, hkey, 1+hkey_len, hval, hval_len, 1);
         }
     }
-    zval_dtor(z_ret);
+    /* replace */
+    zval_dtor(z_tab);
+    *z_tab = *z_ret;
+    zval_copy_ctor(z_tab);
+
     efree(z_ret);
 }