remove sketchy LikelyFalse error
#645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error would trigger on `l:0` on the basis that this is equivalent to `u:0` but always less efficient. There are no other "linting" errors like this in this library, and the C++ implementation doesn't have it, so we should drop it.
Member
Author
|
CI is broken because of rust-lang/rust#121684 |
Member
Author
|
Added a pile of commits and filed an issue on rustc to fix CI. |
apoelstra
force-pushed
the
2024-02--likely-false
branch
from
138559e to
50db03c
Compare
Contributor
|
I can't properly ack because I don't feel super confident with my knowledge of the repo (talking about b87b4fb) but LGTM |
tcharding
approved these changes
Feb 28, 2024
Member
Author
|
cc @sanket1729 can you ACK at least the first commit here? |
Member
|
Sure. Will do in 10 mins |
1 similar comment
Member
|
Sure. Will do in 10 mins |
sanket1729
approved these changes
Feb 28, 2024
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…error 50db03c9620f052740c370362b3498a7ad483a8c cargo fmt (Andrew Poelstra) 220f101f4cb4631f0a6c1d8226081a3acaee0ebf ci: screw up imports for rust-lang/rust#121684 (Andrew Poelstra) df069afe553c701215a800ce6cd234883e60e6bb ci: remove unnecessary imports of `bitcoin` (Andrew Poelstra) 3725549e92fdaee24a23e1c96ada1e4c3a33e60c ci: tighten import of `Vec` (Andrew Poelstra) d441ccd4671c5e3638882d780dabfecb3ae23b78 ci: remove imports that are redundant with super::* (Andrew Poelstra) b87b4fba8ffb2712e0b5a67cddf77d5dfc690a6b remove sketchy `LikelyFalse` error (Andrew Poelstra) Pull request description: This error would trigger on `l:0` on the basis that this is equivalent to `u:0` but always less efficient. There are no other "linting" errors like this in this library, and the C++ implementation doesn't have it, so we should drop it. Fixes #633 ACKs for top commit: tcharding: ACK 50db03c9620f052740c370362b3498a7ad483a8c sanket1729: ACK 50db03c9620f052740c370362b3498a7ad483a8c Tree-SHA512: 30681e6abe7957b9fbe059e808d8057fd174ea156d1853960370d2fd63b032a500f85965a5c7424764df76ed804c62d9a781ae38cdc2b123e9b4b53308dd89f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error would trigger on
l:0on the basis that this is equivalent tou:0but always less efficient. There are no other "linting" errors like this in this library, and the C++ implementation doesn't have it, so we should drop it.Fixes #633