Skip to content

Added array_permutations (attempt 2) #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ronnodas wants to merge 18 commits into
base: master
Choose a base branch
from
+200 −104
Open

Added array_permutations (attempt 2) #1014

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e27b3ee
Treat k==0 less special
phimuemue Jan 8, 2025
8ae44e0
Treat k==0 less special (2)
phimuemue Jan 8, 2025
9b3d6e2
Introduce MaybeConstSize
phimuemue Jan 8, 2025
5003927
PoolIndex<T> -> PoolIndex
phimuemue Jan 8, 2025
5826470
MaybeConstSize (2)
phimuemue Jan 8, 2025
aa90cbb
Express some things via PoolIndex/MaybeConstUsize
phimuemue Jan 8, 2025
98b79de
Try to use PoolIndex for permutations
phimuemue Jan 8, 2025
79f52b2
Move MaybeConstUsize, PoolIndex to lazy_buffer
ronnodas Jan 13, 2025
85a84bd
Rename PoolIndex to ArrayOrVecHelper
ronnodas Jan 13, 2025
6056b73
Rename ArrayOrVecHelper::from_fn to item_from_fn
ronnodas Jan 13, 2025
99de003
Use Idx type directly in PermutationState
ronnodas Jan 13, 2025
d8de4b8
Use Box<[usize]> instead of Vec<usize> in Permutations
ronnodas Jan 13, 2025
57fff6e
Use ArrayOrVecHelper::start in {Array,}Combinations
ronnodas Jan 13, 2025
0b96072
Update ArrayOrVecHelper doc comments
ronnodas Jan 13, 2025
406eac2
Avoid `use ... as _`
ronnodas Jan 13, 2025
1348785
Specify generic in `ArrayCombinations::new`
ronnodas Jan 13, 2025
3dd45f5
Add `debug_assert` in advancing `PermutationState::Buffered`
ronnodas Jan 16, 2025
5a7c522
Use `last_mut()?` instead of indexing
ronnodas Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MaybeConstSize (2)
  • Loading branch information
@phimuemue @ronnodas
phimuemue authored and ronnodas committed Jan 9, 2025
commit 582647022ac05c1ae43f1bca2cd6391469f0c5da
3 changes: 2 additions & 1 deletion src/combinations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,11 @@ pub struct CombinationsGeneric<I: Iterator, Idx> {
first: bool,
}

pub trait MaybeConstUsize {
pub trait MaybeConstUsize : Clone + Copy + std::fmt::Debug {
/*TODO const*/fn value(self) -> usize;
}

#[derive(Clone, Copy, Debug)]
pub struct ConstUsize<const N: usize>;
impl<const N: usize> MaybeConstUsize for ConstUsize<N> {
fn value(self) -> usize {
Expand Down