Skip to content

Commit ee0d30b

Browse files
committed
Added the necessary comments for all the skips in the libc-test/build.rs
1 parent 02bad4b commit ee0d30b

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

libc-test/build.rs

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3334,7 +3334,8 @@ fn test_neutrino(target: &str) {
33343334
}
33353335

33363336
fn which_vxworks() -> Option<(u32, u32)> {
3337-
let version = env::var("WIND_RELEASE_ID").ok()?;
3337+
let version = env::var("WIND_RELEASE_ID").ok()?; // When in VxWorks setup, WIND_RELEASE_ID is
3338+
// always set as the version of the release.
33383339

33393340
let mut pieces = version.trim().split(['.']);
33403341

@@ -3430,8 +3431,12 @@ fn test_vxworks(target: &str) {
34303431
cfg.skip_const(move |constant| match constant.ident() {
34313432
// sighandler_t weirdness
34323433
"SIG_DFL" | "SIG_ERR" | "SIG_IGN"
3433-
// This is not defined in vxWorks
3434-
| "RTLD_DEFAULT" | "S_ISVTX" | "SIGIO" | "SIGWINCH" | "SIGLOST" | "PRIO_PROCESS" => true,
3434+
// These are not defined in VxWorks
3435+
| "RTLD_DEFAULT" | "PRIO_PROCESS"
3436+
// Sticky bits not supported
3437+
| "S_ISVTX"
3438+
// The following are obsolete for VxWorks
3439+
| "SIGIO" | "SIGWINCH" | "SIGLOST" => true,
34353440
_ => false,
34363441
});
34373442
// FIXME(vxworks)
@@ -3444,7 +3449,9 @@ fn test_vxworks(target: &str) {
34443449
move |struct_, field| match (struct_.ident(), field.ident()) {
34453450
("siginfo_t", "si_value")
34463451
| ("stat", "st_size")
3452+
// sighandler_t type is super weird
34473453
| ("sigaction", "sa_sigaction")
3454+
// sa_u_t type is not defined in vxworks
34483455
| ("sigaction", "sa_u") => true,
34493456
_ => false,
34503457
},
@@ -3462,12 +3469,14 @@ fn test_vxworks(target: &str) {
34623469
cfg.skip_fn(move |func| match func.ident() {
34633470
// sighandler_t
34643471
"signal"
3472+
// This is used a realpath and not _realpath
34653473
| "_realpath"
34663474
// not used in static linking by default
34673475
| "dlerror" => true,
34683476
_ => false,
34693477
});
34703478

3479+
// Not defined in vxworks. Just a crate specific union type.
34713480
cfg.skip_union(move |u| u.ident() == "sa_u_t");
34723481

34733482
ctest::generate_test(&mut cfg, "../src/lib.rs", "ctest_output.rs").unwrap();

0 commit comments

Comments
 (0)