-
Notifications
You must be signed in to change notification settings - Fork 1.6k
RFC: let-else statements #3137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
RFC: let-else statements #3137
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2b92ef5
let-else first draft
Fishrock123 3438586
let-else draft updates from zulip
Fishrock123 c131adb
let-else draft updates for if-let-chains
Fishrock123 c9e75dc
let-else draft updates for practical refactor example
Fishrock123 d9e8bd4
let-else draft, add desugar example
Fishrock123 b5c3456
let-else draft, fix let-if-chains example
Fishrock123 059587f
let-else draft, remove old example
Fishrock123 93c1f7c
let-else: rfc PR link
Fishrock123 836f2c4
let-else: inital updates from Josh
Fishrock123 22e8430
let-else: note alternative 'else' names
Fishrock123 d25d51a
let-else: unless -> otherwise
Fishrock123 f3473f6
let-else, multiple updates
Fishrock123 6a9a9ef
let-else, another round of updates
Fishrock123 18ebdca
let-else, avoid let-else within if-let
Fishrock123 324117c
let-else, add note about multiple patterns
Fishrock123 bb81a98
let-else, note let-else-else-chains
Fishrock123 ff866ea
let-else, note that `||` in patterns is still possible
Fishrock123 a4d9456
let-else, update || example desugar
Fishrock123 cab12fc
let-else, variable name spelling
Fishrock123 89c5b6e
let-else, PFCP updates
Fishrock123 54bca55
let-else, fix a never type link
Fishrock123 c0c2fcc
let-else, FCP updates
Fishrock123 76e8bb5
let-else, Mario's edits
Fishrock123 b6b87d6
let-else, disallow any expr ending with `}`.
Fishrock123 952745b
let-else, mention macro expansions
Fishrock123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
let-else, variable name spelling
long sigh
- Loading branch information
commit cab12fc5959fa4ceb12721ef47f6f1fb2363efd2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.