Skip to content

Commit 2e969c7

Browse files
committed
rustdoc(opt): build_impl: check document_private earlier
1 parent 41a79f1 commit 2e969c7

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

src/librustdoc/clean/inline.rs

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -572,30 +572,30 @@ pub(crate) fn build_impl(
572572
super::build_deref_target_impls(cx, &trait_items, ret);
573573
}
574574

575-
// Return if the trait itself or any types of the generic parameters are doc(hidden).
576-
let mut stack: Vec<&Type> = vec![&for_];
575+
if !document_hidden {
576+
// Return if the trait itself or any types of the generic parameters are doc(hidden).
577+
let mut stack: Vec<&Type> = vec![&for_];
577578

578-
if let Some(did) = trait_.as_ref().map(|t| t.def_id())
579-
&& !document_hidden
580-
&& tcx.is_doc_hidden(did)
581-
{
582-
return;
583-
}
584-
585-
if let Some(generics) = trait_.as_ref().and_then(|t| t.generics()) {
586-
stack.extend(generics);
587-
}
588-
589-
while let Some(ty) = stack.pop() {
590-
if let Some(did) = ty.def_id(&cx.cache)
591-
&& !document_hidden
579+
if let Some(did) = trait_.as_ref().map(|t| t.def_id())
592580
&& tcx.is_doc_hidden(did)
593581
{
594582
return;
595583
}
596-
if let Some(generics) = ty.generics() {
584+
585+
if let Some(generics) = trait_.as_ref().and_then(|t| t.generics()) {
597586
stack.extend(generics);
598587
}
588+
589+
while let Some(ty) = stack.pop() {
590+
if let Some(did) = ty.def_id(&cx.cache)
591+
&& tcx.is_doc_hidden(did)
592+
{
593+
return;
594+
}
595+
if let Some(generics) = ty.generics() {
596+
stack.extend(generics);
597+
}
598+
}
599599
}
600600

601601
if let Some(did) = trait_.as_ref().map(|t| t.def_id()) {

0 commit comments

Comments
 (0)