Skip to content

Define fs::hard_link to not follow symlinks. #78026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 5 commits into from
Nov 9, 2020
Merged

Define fs::hard_link to not follow symlinks. #78026

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91a9f83
Define `fs::hard_link` to not follow symlinks.
sunfishcode Oct 16, 2020
23a5c21
Fix a typo in a comment.
sunfishcode Oct 19, 2020
ce00b3e
Use `link` on platforms which lack `linkat`.
sunfishcode Oct 19, 2020
d0178b4
Make it platform-specific whether `hard_link` follows symlinks.
sunfishcode Oct 20, 2020
6249cda
Disable use of `linkat` on Android as well.
sunfishcode Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a typo in a comment.
  • Loading branch information
@sunfishcode
sunfishcode committed Oct 18, 2020
commit 23a5c214150f462043ab411f87ef297309421d71
2 changes: 1 addition & 1 deletion library/std/src/sys/unix/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,7 +1068,7 @@ pub fn link(src: &Path, dst: &Path) -> io::Result<()> {
let src = cstr(src)?;
let dst = cstr(dst)?;
// Use `linkat` with `AT_FDCWD` instead of `link` as `link` leaves it
// implmentation-defined whether it follows symlinks. Pass 0 as the
// implementation-defined whether it follows symlinks. Pass 0 as the
// `linkat` flags argument so that we don't follow symlinks.
cvt(unsafe { libc::linkat(libc::AT_FDCWD, src.as_ptr(), libc::AT_FDCWD, dst.as_ptr(), 0) })?;
Ok(())
Expand Down