Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Inline two more methods
  • Loading branch information
bjorn3 committed Jun 8, 2021
commit 9d9ccec3fc416965dabd1851369a10315754a922
38 changes: 14 additions & 24 deletions compiler/rustc_interface/src/passes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,15 +102,15 @@ pub enum Action {
}

#[derive(PartialEq)]
pub struct Marker<T>(PhantomData<T>);
struct Marker<T>(PhantomData<T>);

impl<T> Marker<T> {
pub unsafe fn new() -> Self {
unsafe fn new() -> Self {
Marker(PhantomData)
}
}

pub enum YieldType<I, A> {
enum YieldType<I, A> {
Initial(I),
Accessor(Marker<A>),
}
Expand Down Expand Up @@ -174,16 +174,15 @@ impl BoxedResolver {
r.unwrap()
}

pub fn complete(mut self) -> ResolverOutputs {
// Tell the generator we want it to complete, consuming it and yielding a result
let result = self.generator.as_mut().resume(Action::Complete);
if let GeneratorState::Complete(r) = result { r } else { panic!() }
}

fn initial_yield(
value: Result<ast::Crate>,
) -> YieldType<Result<ast::Crate>, fn(&mut Resolver<'_>)> {
YieldType::Initial(value)
pub fn to_resolver_outputs(resolver: Rc<RefCell<BoxedResolver>>) -> ResolverOutputs {
match Rc::try_unwrap(resolver) {
Ok(resolver) => {
// Tell the generator we want it to complete, consuming it and yielding a result
let result = resolver.into_inner().generator.as_mut().resume(Action::Complete);
if let GeneratorState::Complete(r) = result { r } else { panic!() }
}
Err(resolver) => resolver.borrow_mut().access(|resolver| resolver.clone_outputs()),
}
}
}

Expand Down Expand Up @@ -221,11 +220,11 @@ pub fn configure_and_expand(
);
let mut resolver = match res {
Err(v) => {
yield BoxedResolver::initial_yield(Err(v));
yield YieldType::Initial(Err(v));
panic!()
}
Ok((krate, resolver)) => {
action = yield BoxedResolver::initial_yield(Ok(krate));
action = yield YieldType::Initial(Ok(krate));
resolver
}
};
Expand Down Expand Up @@ -253,15 +252,6 @@ pub fn configure_and_expand(
result.map(|k| (k, resolver))
}

impl BoxedResolver {
pub fn to_resolver_outputs(resolver: Rc<RefCell<BoxedResolver>>) -> ResolverOutputs {
match Rc::try_unwrap(resolver) {
Ok(resolver) => resolver.into_inner().complete(),
Err(resolver) => resolver.borrow_mut().access(|resolver| resolver.clone_outputs()),
}
}
}

pub fn register_plugins<'a>(
sess: &'a Session,
metadata_loader: &'a dyn MetadataLoader,
Expand Down