Skip to content

barbara gets burned by select #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2021
Merged

barbara gets burned by select #169

merged 2 commits into from
Apr 28, 2021

Conversation

nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis mentioned this pull request Apr 22, 2021
Open
pickfire
pickfire reviewed Apr 23, 2021
View reviewed changes
@rylev
Copy link
Member

rylev commented Apr 23, 2021 •
edited
Loading

I’m all for more stories but is this different enough from https://github.com/rust-lang/wg-async-foundations/blob/master/src/vision/status_quo/alan_builds_a_cache.md? It seems to cover the same exact issue without it being specifically about select!.

In fact the blog post linked here was an inspiration for the “Alan builds a cache” story.

@nikomatsakis
Copy link
Contributor Author

So @rylev I pushed some comments about what makes this story different. I do think that ultimately this story and the others about cancellation would be merged into one tighter narrative, but I'd rather wait to do that until we have assembled all the pieces.

@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Apr 24, 2021 •
edited
Loading

It seems to cover the same exact issue without it being specifically about select!.

As I tried to explain in the text, the whole motivation for writing this story to me was to specifically about select!, and the fact that cancellation of futures requires fine-grained recovery even for normal, expected events. It's not just about "the client dropped the connection, so tear down everything related to it", which is how I thought of it to start.

rylev
rylev reviewed Apr 26, 2021
View reviewed changes
src/vision/status_quo/barbara_gets_burned_by_select.md

They would likely have a hard time diagnosing the problem. It really depends on how well they have come to understand the semantics of cancellation. This is fairly independent from programming language background; knowing non-async Rust doesn't help in particular, as this concept is specific to async code.

### What is different between this story and other cancellation stories?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is fantastic. It's very subtle, but it has big implications. ♥

@nikomatsakis nikomatsakis added the status-quo-story-ideas "Status quo" user story ideas label Apr 28, 2021
@nikomatsakis nikomatsakis merged commit 926057d into rust-lang:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@tomaka tomaka tomaka left review comments

@pickfire pickfire pickfire left review comments

@rylev rylev rylev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status-quo-story-ideas "Status quo" user story ideas

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nikomatsakis @rylev @tomaka @pickfire