Skip to content

Web optimizations #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newpavlov merged 12 commits into from
Dec 9, 2024
Merged

Web optimizations #559

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1dbda17
Cache global `Crypto` object
daxpedda Dec 4, 2024
d804258
Don't create sub-array unless necessary
daxpedda Dec 6, 2024
b2ab9a1
Don't use `Uint8Array` when not necessary
daxpedda Dec 5, 2024
02507fe
Improve CI test matrix
daxpedda Dec 7, 2024
dcd8f4a
Remove nesting
daxpedda Dec 7, 2024
e024029
Remove unnecessary cloning
daxpedda Dec 7, 2024
6feb9b7
Guard `js-sys` dependency behind `target_feature = "atomics"`
daxpedda Dec 7, 2024
65ba727
Fix `MAX_BUFFER_SIZE`
daxpedda Dec 8, 2024
055a7c2
Remove all `as` casts
daxpedda Dec 8, 2024
ec6f289
Use `globalThis` to access `Crypto`
daxpedda Dec 8, 2024
cf72d6c
Remove the `js_sys::Uint8Array` import
daxpedda Dec 9, 2024
e5d68a9
Move check for global `Crypto` object to `getRandomValues`
daxpedda Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use globalThis to access Crypto
  • Loading branch information
@daxpedda
daxpedda committed Dec 8, 2024
commit ec6f28950b94351c3ec5f398ff7dff72971f5e43
2 changes: 1 addition & 1 deletion src/backends/wasm_js.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ extern "C" {
// Web Crypto API: Crypto interface (https://www.w3.org/TR/WebCryptoAPI/)
type Crypto;
// Holds the global `Crypto` object.
#[wasm_bindgen(thread_local_v2, js_name = crypto)]
#[wasm_bindgen(thread_local_v2, js_namespace = globalThis, js_name = crypto)]
static CRYPTO: Option<Crypto>;
// Crypto.getRandomValues()
#[cfg(not(target_feature = "atomics"))]
Expand Down