Determine attachment content_type from filename extension

[mkoeppe]

Currently we use application/octet-stream for everything, but the importer complains:

now="2023-01-10T14:38:37Z" guid=cae4a192-8fed-11ed-84b0-230110063154 command=import fn="GitHub::Migrator::AttachmentImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=github/migrator/attachment_importer/user_asset_extended_content_types model_id=1 field=name validation_error="has a file extension that does not match the content type"

[mkoeppe]

using https://docs.python.org/3/library/mimetypes.html

[mkoeppe]

Now we get

now="2023-01-10T17:19:03Z" guid=cae4a192-8fed-11ed-84b0-230110091223 command=import fn="GitHub::Migrator::AttachmentImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=github/migrator/attachment_importer/user_asset_extended_content_types model_id=3 field=content_type validation_error="is not included in the list"
now="2023-01-10T17:19:03Z" guid=cae4a192-8fed-11ed-84b0-230110091223 command=import fn="GitHub::Migrator::AttachmentImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=github/migrator/attachment_importer/user_asset_extended_content_types model_id=3 field=name validation_error="has a file extension that does not match the content type"

for

[
{
    "asset_content_type": "text/html",
    "asset_name": "mathjax2canvas_threejs.html",
    "asset_url": "tarball://root/attachments/ticket30226/mathjax2canvas_threejs.html",
    "created_at": "2020-07-28T04:01:22Z",
    "issue": "https://github.com/sagemath/sage/issues/30226",
    "repository": "https://github.com/sagemath/sage",
    "type": "attachment",
    "url": "https://github.com/sagemath/sage/files/ticket30226/mathjax2canvas_threejs.html",
    "user": "https://github.com/jcamp0x2a"
}]

Apparently some attachment types need to be mapped to repository_file instead, like this:

  {
    "type": "repository_file",
    "url": "https://github.com/sagemath/trac-to-github/files/10328067/test_attachment.txt",
    "repository": "https://github.com/sagemath/trac-to-github",
    "user": "https://github.com/mkoeppe",
    "file_name": "test_attachment.txt",
    "file_content_type": "text/plain",
    "file_url": "tarball://root/repository_files/10328067/test_attachment.txt",
    "created_at": "2022-12-31T22:46:33Z"
  }

[mkoeppe]

Same problem with repository_file

now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=2 field=name validation_error="has a file extension that does not match the content type"
now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=3 field=name validation_error="has a file extension that does not match the content type"
now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=4 field=content_type validation_error="is not included in the list"
now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=4 field=name validation_error="has a file extension that does not match the content type"
now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=5 field=content_type validation_error="is not included in the list"
now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=5 field=name validation_error="has a file extension that does not match the content type"
now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=6 field=content_type validation_error="is not included in the list"
now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=6 field=name validation_error="has a file extension that does not match the content type"
now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=7 field=content_type validation_error="is not included in the list"
now="2023-01-10T21:25:11Z" guid=cae4a192-8fed-11ed-84b0-230110131425 command=import fn="GitHub::Migrator::RepositoryFileImporter#import_model" class="ActiveRecord::RecordInvalid" model_name=repository_file model_id=7 field=name validation_error="has a file extension that does not match the content type"

[mkoeppe]

Fixed by 14edd3e