Skip to content

Commit 756fcd3

Browse files
authored
Fix the logger option for render() (#1538)
Closes #1533
1 parent 5606602 commit 756fcd3

File tree

5 files changed

+16
-4
lines changed

5 files changed

+16
-4
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## 1.43.4
2+
3+
### JS API
4+
5+
* Fix a bug where the `logger` option was ignored for the `render()` function.
6+
17
## 1.43.3
28

39
* Improve performance.

lib/src/node/legacy.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,9 @@ Future<RenderResult> _renderAsync(RenderOptions options) async {
8484
quietDeps: options.quietDeps ?? false,
8585
verbose: options.verbose ?? false,
8686
charset: options.charset ?? true,
87-
sourceMap: _enableSourceMaps(options));
87+
sourceMap: _enableSourceMaps(options),
88+
logger: NodeToDartLogger(
89+
options.logger, Logger.stderr(color: hasTerminal)));
8890
} else if (file != null) {
8991
result = await compileAsync(file,
9092
nodeImporter: _parseImporter(options, start),

pkg/sass_api/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.0.0-beta.18
2+
3+
* No user-visible changes.
4+
15
## 1.0.0-beta.17
26

37
* No user-visible changes.

pkg/sass_api/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ name: sass_api
22
# Note: Every time we add a new Sass AST node, we need to bump the *major*
33
# version because it's a breaking change for anyone who's implementing the
44
# visitor interface(s).
5-
version: 1.0.0-beta.17
5+
version: 1.0.0-beta.18
66
description: Additional APIs for Dart Sass.
77
homepage: https://github.com/sass/dart-sass
88

99
environment:
1010
sdk: '>=2.12.0 <3.0.0'
1111

1212
dependencies:
13-
sass: 1.43.3
13+
sass: 1.43.4
1414

1515
dependency_overrides:
1616
sass: {path: ../..}

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: sass
2-
version: 1.43.3
2+
version: 1.43.4
33
description: A Sass implementation in Dart.
44
homepage: https://github.com/sass/dart-sass
55

0 commit comments

Comments
 (0)