fix(ios): improve safe area layout lifecycle (tidev#14269)

* fix(ios): improve safe area layout lifecycle

* chore: use BOOL instead of bool

* Update iphone/TitaniumKit/TitaniumKit/Sources/API/TiViewProxy.m

---------

Co-authored-by: Hans Knöchel <[email protected]>

Author: janvennemann

iphone/TitaniumKit/TitaniumKit/Sources/API/TiLayoutQueue.m

@@ -74,6 +74,8 @@ + (void)layoutProxy:(TiViewProxy *)thisProxy
   } else {
     [thisProxy refreshView:nil];
   }
+
+  [thisProxy didFinishLayout];
 }
 
 + (void)addViewProxy:(TiViewProxy *)newViewProxy

iphone/TitaniumKit/TitaniumKit/Sources/API/TiViewProxy.h

@@ -535,6 +535,11 @@ enum {
  */
 - (void)parentWillHide;
 
+/**
+ Tells the view proxy that rendering via the layout queue finished.
+ */
+- (void)didFinishLayout;
+
 #pragma mark Layout actions
 
 - (void)refreshView:(TiUIView *)transferView;

iphone/TitaniumKit/TitaniumKit/Sources/API/TiViewProxy.m

@@ -2083,6 +2083,13 @@ - (void)parentWillHide
   }
 }
 
+- (void)didFinishLayout
+{
+  VerboseLog(@"[INFO] Did finish layout for %@", self);
+
+  // No-op, can be overridden by subclasses.
+}
+
 #pragma mark Layout actions
 
 // Need this so we can overload the sandbox bounds on split view detail/master
@@ -2286,9 +2293,12 @@ - (void)relayout
     if ([self respondsToSelector:@selector(processForSafeArea)]) {
       TiUIWindowProxy *windowProxy = (TiUIWindowProxy *)self;
 
-      [windowProxy processForSafeArea];
-      layoutChanged = layoutChanged || windowProxy.safeAreaInsetsUpdated;
-      windowProxy.safeAreaInsetsUpdated = NO;
+      BOOL safeAreaInsetsChanged = [windowProxy processForSafeArea];
+      layoutChanged = layoutChanged || safeAreaInsetsChanged;
+      if (safeAreaInsetsChanged && windowProxy.pendingSafeAreaUpdate) {
+        // Reset the pending safe area update here because it was already updated in the current layout cycle
+        windowProxy.pendingSafeAreaUpdate = NO;
+      }
     }
 
     if (layoutChanged && [self _hasListeners:@"postlayout" checkParent:NO]) {

iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.h

@@ -38,9 +38,9 @@
 @property (nonatomic, readonly) TiProxy *tabGroup;
 @property (nonatomic) BOOL isMasterWindow;
 @property (nonatomic) BOOL isDetailWindow;
-@property (nonatomic) BOOL safeAreaInsetsUpdated;
+@property (nonatomic) BOOL pendingSafeAreaUpdate;
 
-- (void)processForSafeArea;
+- (BOOL)processForSafeArea;
 - (UIViewController *)windowHoldingController;
 - (TiUIiOSTransitionAnimationProxy *)transitionAnimation;
 

iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.m

@@ -94,6 +94,28 @@ - (BOOL)suppressesRelayout
   return [super suppressesRelayout];
 }
 
+- (void)didFinishLayout
+{
+  if (self.pendingSafeAreaUpdate) {
+    self.pendingSafeAreaUpdate = NO;
+    [self willChangeSizeForSafeArea];
+  }
+
+  [super didFinishLayout];
+}
+
+- (void)willChangeSizeForSafeArea
+{
+  if ((*((char *)&dirtyflags) & (1 << (7 - TiRefreshViewSize))) != 0) {
+    // Layout is in progress, defer the safe area update
+    self.pendingSafeAreaUpdate = YES;
+    return;
+  }
+
+  // Proceed with normal size change logic
+  [self willChangeSize];
+}
+
 #pragma mark - Utility Methods
 - (void)windowWillOpen
 {
@@ -762,7 +784,7 @@ - (void)viewWillAppear:(BOOL)animated
 
 - (void)viewSafeAreaInsetsDidChange
 {
-  [self willChangeSize];
+  [self willChangeSizeForSafeArea];
 }
 
 - (void)viewWillDisappear:(BOOL)animated
@@ -977,9 +999,10 @@ - (void)setTransitionAnimation:(id)args
   [self rememberProxy:transitionProxy];
 }
 
-- (void)processForSafeArea
+- (BOOL)processForSafeArea
 {
   // Overridden in subclass
+  return NO;
 }
 
 @end

iphone/TitaniumKit/TitaniumKit/Sources/Modules/TiUIWindowProxy.m

@@ -1074,7 +1074,7 @@ - (TiViewProxy *)safeAreaView
   return self.safeAreaViewProxy;
 }
 
-- (void)processForSafeArea
+- (BOOL)processForSafeArea
 {
   [self setValue:@{ @"top" : NUMFLOAT(0.0),
     @"left" : NUMFLOAT(0.0),
@@ -1096,18 +1096,17 @@ - (void)processForSafeArea
     edgeInsets = [self defaultEdgeInsetsForSafeAreaInset:safeAreaInset];
   }
 
+  [self setValue:@{ @"top" : NUMFLOAT(edgeInsets.top),
+    @"left" : NUMFLOAT(edgeInsets.left),
+    @"bottom" : NUMFLOAT(edgeInsets.bottom),
+    @"right" : NUMFLOAT(edgeInsets.right) }
+          forKey:@"safeAreaPadding"];
+
+  BOOL safeAreaInsetsChanged = !UIEdgeInsetsEqualToEdgeInsets(edgeInsets, oldSafeAreaInsets);
+  oldSafeAreaInsets = edgeInsets;
+
   if (self.shouldExtendSafeArea) {
-    [self setValue:@{ @"top" : NUMFLOAT(edgeInsets.top),
-      @"left" : NUMFLOAT(edgeInsets.left),
-      @"bottom" : NUMFLOAT(edgeInsets.bottom),
-      @"right" : NUMFLOAT(edgeInsets.right) }
-            forKey:@"safeAreaPadding"];
-
-    if (!UIEdgeInsetsEqualToEdgeInsets(edgeInsets, oldSafeAreaInsets)) {
-      self.safeAreaInsetsUpdated = YES;
-    }
-    oldSafeAreaInsets = edgeInsets;
-    return;
+    return safeAreaInsetsChanged;
   }
 
   TiViewProxy *safeAreaProxy = [self safeAreaViewProxy];
@@ -1128,6 +1127,8 @@ - (void)processForSafeArea
   if (!oldRight || [oldRight floatValue] != edgeInsets.right) {
     [safeAreaProxy setRight:NUMFLOAT(edgeInsets.right)];
   }
+
+  return safeAreaInsetsChanged;
 }
 
 - (UIEdgeInsets)tabGroupEdgeInsetsForSafeAreaInset:(UIEdgeInsets)safeAreaInset