Skip to content

Commit 1b01442

Browse files
Liudmila Molkovajsuereth
authored andcommitted
BREAKING: Replace net.peer.*/net.host.* with client.*/server.* (and source.*/destination.*) (open-telemetry#3402)
1 parent f4f8be2 commit 1b01442

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

specification/common/attribute-requirement-level.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ All instrumentations MUST populate the attribute when the given condition is sat
5050

5151
When a `Conditionally Required` attribute's condition is not satisfied, and there is no requirement to populate the attribute, semantic conventions MAY provide special instructions on how to handle it. If no instructions are given and if instrumentation can populate the attribute, instrumentation SHOULD use the `Opt-In` requirement level on the attribute.
5252

53-
For example, `net.peer.name` is `Conditionally Required` by the [Database convention](../trace/semantic_conventions/database.md) when available. When `net.sock.peer.addr` is available instead, instrumentation can do a DNS lookup, cache and populate `net.peer.name`, but only if the user explicitly enables the instrumentation to do so, considering the performance issues that DNS lookups introduce.
53+
For example, `server.address` is `Conditionally Required` by the [Database convention](../trace/semantic_conventions/database.md) when available. When `server.socket.address` is available instead, instrumentation can do a DNS lookup, cache and populate `server.address`, but only if the user explicitly enables the instrumentation to do so, considering the performance issues that DNS lookups introduce.
5454

5555
## Recommended
5656

@@ -69,6 +69,6 @@ This attribute requirement level is recommended for attributes that are particul
6969

7070
Here are several examples of expensive operations to be avoided by default:
7171

72-
- DNS lookups to populate `net.peer.name` when only an IP address is available to the instrumentation. Caching lookup results does not solve the issue for all possible cases and should be avoided by default too.
72+
- DNS lookups to populate `server.address` when only an IP address is available to the instrumentation. Caching lookup results does not solve the issue for all possible cases and should be avoided by default too.
7373
- forcing an `http.route` calculation before the HTTP framework calculates it
7474
- reading response stream to find `http.response_content_length` when `Content-Length` header is not available

0 commit comments

Comments
 (0)