Skip to content

DefaultModuleService: change persisting of items #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

DefaultModuleService: change persisting of items #236

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
876e9bf
DefaultModuleService: change persisting of items
stelfrich Mar 24, 2016
d725de5
Parameter: update initializer() documentation
stelfrich Mar 24, 2016
04e9442
Add test for persistance behavior of ModuleItems
stelfrich Jun 7, 2016
44029b6
ModuleServiceText: clean up
stelfrich Jul 2, 2016
b4e8a32
Add ItemPersistence to denote persistence behavior
stelfrich Aug 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
DefaultModuleService: change persisting of items 
Disable the persisting of a ModuleItems if an initialize() method is set
and is not empty. This way, initialize() can overwrite the value of a
ModuleItem even if persist=true is assumed implicitly.

See:
* imagej/imagej-legacy#137 (comment)
  • Loading branch information
@stelfrich
stelfrich committed Aug 8, 2016
commit 876e9bf6c9186a38c69511d198b2fb72273bce7b
3 changes: 3 additions & 0 deletions src/main/java/org/scijava/module/DefaultModuleService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ public ModuleItem<?> getSingleOutput(Module module, Collection<Class<?>> types)
public <T> void save(final ModuleItem<T> item, final T value) {
if (!item.isPersisted()) return;

// NB: Do not persist values which are computed via an initializer.
if (item.getInitializer() != null && !item.getInitializer().isEmpty()) return;

if (MiscUtils.equal(item.getDefaultValue(), value)) {
// NB: Do not persist the value if it is the default.
// This is nice if the default value might change later,
Expand Down