Commit 17ce47c
authored
Implement AsRef for Schema and Field (apache#8417)
# Which issue does this PR close?
- closes apache#5819
# Rationale for this change
This allows writing generic code that accepts `&Field`, `Arc<Field>` or
`&Arc<Field>`, or iterators of these. Same for `Schema`.
# What changes are included in this PR?
`impl AsRef<Field> for Field`
`impl AsRef<Schema> for Schema`
as suggested by `AsRef` own docs
# Are these changes tested?
yes
# Are there any user-facing changes?
it does not break API. Downstream crates cannot implement `AsRef<Field>
for Field`
Downstream crates cannot workaround these either -
apache#5819 (comment)1 parent 0737c61 commit 17ce47c
2 files changed
+61
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
175 | 181 | | |
176 | 182 | | |
177 | 183 | | |
| |||
1259 | 1265 | | |
1260 | 1266 | | |
1261 | 1267 | | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
| 1276 | + | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
| 1280 | + | |
| 1281 | + | |
| 1282 | + | |
| 1283 | + | |
| 1284 | + | |
| 1285 | + | |
| 1286 | + | |
| 1287 | + | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
1262 | 1298 | | |
1263 | 1299 | | |
1264 | 1300 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
546 | 546 | | |
547 | 547 | | |
548 | 548 | | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
549 | 555 | | |
550 | 556 | | |
551 | 557 | | |
552 | 558 | | |
553 | 559 | | |
554 | 560 | | |
555 | 561 | | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
556 | 581 | | |
557 | 582 | | |
558 | 583 | | |
| |||
0 commit comments