Skip to content

Commit 78b874e

Browse files
committed
Do not to call app.address() before listening event
According to nodejs/node-v0.x-archive@d3f6b09, call to `net.Server.address()` should happen only after `net.Server` emits `listening` event.
1 parent 5c50e3a commit 78b874e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

bin/express

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,9 @@ var app = [
185185
, ''
186186
, 'app.get(\'/\', routes.index);'
187187
, ''
188-
, 'app.listen(3000);'
189-
, 'console.log("Express server listening on port %d in %s mode", app.address().port, app.settings.env);'
188+
, 'app.listen(3000, function(){'
189+
, ' console.log("Express server listening on port %d in %s mode", app.address().port, app.settings.env);'
190+
, '});'
190191
, ''
191192
].join(eol);
192193

0 commit comments

Comments
 (0)