From 8ce4a4484846f3e0f39317f6320c0736d77ecb3f Mon Sep 17 00:00:00 2001 From: Christer Edvartsen Date: Tue, 11 Sep 2012 19:22:56 +0200 Subject: [PATCH] Implemented support for parenthesis after method names in the covers annotation --- PHP/CodeCoverage.php | 2 +- Tests/PHP/CodeCoverageTest.php | 13 ++++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/PHP/CodeCoverage.php b/PHP/CodeCoverage.php index a33573679..90e47d2b8 100644 --- a/PHP/CodeCoverage.php +++ b/PHP/CodeCoverage.php @@ -633,7 +633,7 @@ protected function getLinesToBeCovered($className, $methodName) } $match = preg_match_all( - '(@covers\s+(?P.*?)\s*$)m', + '(@covers\s+(?P.*?)\s*(\(\s*\))?\s*$)m', $docComment, $matches ); diff --git a/Tests/PHP/CodeCoverageTest.php b/Tests/PHP/CodeCoverageTest.php index efccd207b..d192d2e3c 100644 --- a/Tests/PHP/CodeCoverageTest.php +++ b/Tests/PHP/CodeCoverageTest.php @@ -82,7 +82,7 @@ protected function setUp() $this->getLinesToBeCovered = new ReflectionMethod( 'PHP_CodeCoverage', 'getLinesToBeCovered' ); - + $this->getLinesToBeCovered->setAccessible(TRUE); } @@ -235,10 +235,13 @@ public function testClear() } /** - * @covers PHP_CodeCoverage::start - * @covers PHP_CodeCoverage::stop - * @covers PHP_CodeCoverage::append - * @covers PHP_CodeCoverage::applyListsFilter + * Add parenthesis to the covers annotation below in a couple of different ways to make sure it + * works as expected + * + * @covers PHP_CodeCoverage::start() + * @covers PHP_CodeCoverage::stop( ) + * @covers PHP_CodeCoverage::append () + * @covers PHP_CodeCoverage::applyListsFilter ( ) * @covers PHP_CodeCoverage::initializeFilesThatAreSeenTheFirstTime * @covers PHP_CodeCoverage::applyCoversAnnotationFilter * @covers PHP_CodeCoverage::getTests