We need to return immediately from our variant reply parsing

michael-grunder · michael-grunder · commit d2832bfa8553 · 2014-02-20T15:48:15.000-08:00
function if we get a protocol error, rather than just throwing and exception and breaking execution of the loop. Addresses phpredis#437
diff --git a/library.c b/library.c
@@ -1824,7 +1824,7 @@ redis_read_variant_reply(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock, zv
 		default:
 			// Protocol error
 			zend_throw_exception_ex(redis_exception_ce, 0 TSRMLS_CC, "protocol error, got '%c' as reply-type byte\n", reply_type);
-			break;
+            return FAILURE;
 	}
 
 	IF_MULTI_OR_PIPELINE() {

Original file line number	Diff line number	Diff line change
`@@ -1824,7 +1824,7 @@ redis_read_variant_reply(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock, zv`
`1824`	`1824`	`default:`
`1825`	`1825`	`// Protocol error`
`1826`	`1826`	`zend_throw_exception_ex(redis_exception_ce, 0 TSRMLS_CC, "protocol error, got '%c' as reply-type byte\n", reply_type);`
`1827`		`- break;`
	`1827`	`+ return FAILURE;`
`1828`	`1828`	`}`
`1829`	`1829`
`1830`	`1830`	`IF_MULTI_OR_PIPELINE() {`