Skip to content

Commit 8ccd130

Browse files
committed
Refactor CMake for better UWP support
1 parent a7e49f5 commit 8ccd130

File tree

18 files changed

+288
-363
lines changed

18 files changed

+288
-363
lines changed

Release/CMakeLists.txt

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,9 @@ elseif(WIN32)
125125
if(NOT BUILD_SHARED_LIBS)
126126
# This causes cmake to not link the test libraries separately, but instead hold onto their object files.
127127
set(TEST_LIBRARY_TARGET_TYPE OBJECT)
128-
set(Casablanca_DEFINITIONS -D_NO_ASYNCRTIMP -D_NO_PPLXIMP CACHE INTERNAL "Definitions for consume casablanca library")
129-
else()
130-
set(Casablanca_DEFINITIONS "" CACHE INTERNAL "Definitions for consume casablanca library")
131128
endif()
132-
add_definitions(${Casablanca_DEFINITIONS} -D_WINSOCK_DEPRECATED_NO_WARNINGS)
129+
130+
add_definitions(-D_WINSOCK_DEPRECATED_NO_WARNINGS)
133131
else()
134132
message(FATAL_ERROR "-- Unsupported Build Platform.")
135133
endif()
@@ -198,16 +196,15 @@ function(add_casablanca_test NAME SOURCES_VAR)
198196
add_library(${NAME} ${TEST_LIBRARY_TARGET_TYPE} ${${SOURCES_VAR}})
199197
message("-- Added test library ${NAME}")
200198
if(TEST_LIBRARY_TARGET_TYPE STREQUAL "OBJECT")
201-
foreach(_dep httptest_utilities common_utilities unittestpp cpprest)
199+
foreach(_dep cpprest common_utilities unittestpp)
202200
target_include_directories(${NAME} PRIVATE $<TARGET_PROPERTY:${_dep},INTERFACE_INCLUDE_DIRECTORIES>)
203201
target_compile_definitions(${NAME} PRIVATE $<TARGET_PROPERTY:${_dep},INTERFACE_COMPILE_DEFINITIONS>)
204202
endforeach()
205203
else()
206-
target_link_libraries(${NAME}
207-
httptest_utilities
204+
target_link_libraries(${NAME} PRIVATE
205+
cpprest
208206
common_utilities
209207
unittestpp
210-
cpprest
211208
${ANDROID_STL_FLAGS}
212209
)
213210
if (BUILD_SHARED_LIBS)

Release/cmake/cpprest_find_boost.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ function(cpprest_find_boost)
3535
if(_prev STREQUAL "optimized")
3636
list(APPEND _libs "$<$<NOT:$<CONFIG:Debug>>:${_lib}>")
3737
elseif(_prev STREQUAL "debug")
38-
list(APPEND _libs "$<$<CONFIG:Debug>:${_lib}>")
38+
list(APPEND _libs "$<$<CONFIG:Debug>:${_lib}>")
3939
else()
40-
list(APPEND _libs "${_lib}")
40+
list(APPEND _libs "${_lib}")
4141
endif()
4242
endif()
4343
set(_prev "${_lib}")

0 commit comments

Comments
 (0)