Skip to content

Conversation

@tadhglewis
Copy link
Contributor

@tadhglewis tadhglewis commented Jan 27, 2023

The problem: I need a api endpoint to generate auth tokens for local development. With sku I can simply use dev server middleware however this isn't possible when running storybook.

Storybook actually supports a router middleware since 2016 however it isn't currently documented as per storybookjs/storybook#15300 (comment) so it
might be debatable whether we want to support it in sku.

There is probably a larger discussion to be had around a better implementation for storybook as configuring storybook through .storybook/* directory isn't supported in sku projects - talked to @askoufis here

Todo

  • fix broken tests
  • check if this is something we should actually support
  • make sure it won't break existing storybook projects

@tadhglewis tadhglewis requested a review from a team as a code owner January 27, 2023 05:30
@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2023

⚠️ No Changeset found

Latest commit: 65e8910

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tadhglewis tadhglewis changed the title PoC: support storybook middleware Proof of concept: support storybook middleware Jan 27, 2023
@tadhglewis tadhglewis marked this pull request as draft January 27, 2023 05:48
@tadhglewis
Copy link
Contributor Author

Closing in favor of supporting supporting config dir or dangerously override

@tadhglewis tadhglewis closed this Jan 30, 2023
@askoufis askoufis deleted the storybook-middleware branch June 23, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants