Merge pull request #3 from Driftt/test-identify-on-page

add a test that identify() gets called on page load

Author: trun

Makefile

@@ -70,7 +70,7 @@ lint: node_modules
 # Test locally in PhantomJS.
 test-phantomjs: node_modules build.js
 	@$(DUOT) phantomjs $(TESTS_DIR) args: \
-		--ignore-ssl-errors=true --path node_modules/.bin/phantomjs
+		--ignore-ssl-errors=true --ssl-protocol=tlsv1 --path node_modules/.bin/phantomjs
 .PHONY: test-phantomjs
 
 # Test locally in the browser.

lib/index.js

@@ -103,8 +103,9 @@ function convertDate(date) {
  */
 
 Drift.prototype.page = function(page) {
-  if (!this.identified && page.userId()) {
-    window.drift.identify(page.userId());
+  var userId = this.analytics.user().id();
+  if (!this.identified && userId) {
+    window.drift.identify(userId);
     this.identified = true;
   }
 

test/index.test.js

@@ -106,5 +106,43 @@ describe('Drift', function() {
         analytics.called(window.drift.track, 'event', { date: Math.floor(date / 1000) });
       });
     });
+
+    describe('#page', function() {
+      beforeEach(function() {
+        analytics.stub(window.drift, 'page');
+        analytics.stub(window.drift, 'identify');
+      });
+
+      it('should send a page view event but not an identify event', function() {
+        // track a page view
+        analytics.page('page');
+
+        analytics.called(window.drift.page, 'page');
+        analytics.didNotCall(window.drift.identify);
+      });
+
+      it('should send an page view event but only one identify event', function() {
+        // set the user id by calling identify
+        analytics.identify('id');
+        analytics.calledOnce(window.drift.identify);
+
+        // track a page view
+        analytics.page('page');
+
+        analytics.called(window.drift.page, 'page');
+        analytics.calledOnce(window.drift.identify);
+      });
+
+      it('should send a page view event and an identify event', function() {
+        // set the user id explicitly
+        analytics.user().id('id');
+
+        // track a page view
+        analytics.page('page');
+
+        analytics.called(window.drift.page, 'page');
+        analytics.calledOnce(window.drift.identify, 'id');
+      });
+    });
   });
 });