Skip to content
This repository was archived by the owner on Dec 12, 2019. It is now read-only.

Commit b5081ac

Browse files
ashishpal06Han
authored andcommitted
Release 1.2.0
* using segment's page url as canonical, user need not provide canonical url explicitly
1 parent f3b7667 commit b5081ac

File tree

4 files changed

+30
-10
lines changed

4 files changed

+30
-10
lines changed

HISTORY.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
1.2.0 / 2017-05-28
2+
==================
3+
4+
* Bugs Fixed, pageUrl treated as canonicalUrl
5+
16
1.1.0 / 2017-05-28
27
==================
38

lib/index.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,9 @@ Wigzo.prototype.productClicked = function(track) {
160160
title: track.name(),
161161
price: track.currency() + ' ' + track.price(),
162162
category: track.category(),
163+
canonicalUrl: track.proxy('context.page.url'),
163164
/* custom props */
164165
image: options.imageUrl,
165-
canonicalUrl: options.canonicalUrl,
166166
description: options.description,
167167
language:options.language
168168
});
@@ -181,9 +181,9 @@ Wigzo.prototype.productViewed = function(track) {
181181
title: track.name(),
182182
price: track.currency() + ' ' + track.price(),
183183
category: track.category(),
184+
canonicalUrl: track.proxy('context.page.url'),
184185
/* custom props */
185186
image: options.imageUrl,
186-
canonicalUrl: options.canonicalUrl,
187187
description: options.description,
188188
language:options.language
189189
});
@@ -227,5 +227,9 @@ Wigzo.prototype.track = function(track) {
227227
*/
228228

229229
Wigzo.prototype.page = function(page) {
230-
window.wigzo.track('view', page.properties());
230+
var pageData = reject({
231+
canonicalUrl: page.url(),
232+
title: page.name()
233+
});
234+
window.wigzo.track('view',pageData);
231235
};

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@segment/analytics.js-integration-wigzo",
3-
"version": "1.1.0",
3+
"version": "1.2.0",
44
"description": "The wigzo analytics.js integration.",
55
"main": "lib/index.js",
66
"directories": {

test/index.test.js

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,15 +82,22 @@ describe('Wigzo', function() {
8282
});
8383

8484
it('should pass page name and default properties via page', function() {
85-
analytics.page('Name');
86-
analytics.called(window.wigzo.track, 'view');
85+
var wigzoPageData = {
86+
title: 'Dummy Page Name',
87+
canonicalUrl: 'https://snoopy.wigzopush.com/index.php?route=product/product&product_id=40'
88+
};
89+
analytics.page(wigzoPageData.title, {
90+
url : wigzoPageData.canonicalUrl
91+
});
92+
analytics.called(window.wigzo.track, 'view', wigzoPageData);
8793
});
8894
});
8995

9096
describe('#ecommerce', function() {
9197
beforeEach(function() {
9298
analytics.stub(window.wigzo, 'index');
9399
analytics.stub(window.wigzo, 'track');
100+
analytics.stub(window.wigzo, 'page');
94101
});
95102

96103
it('product clicked should call index', function() {
@@ -109,6 +116,9 @@ describe('Wigzo', function() {
109116
canonicalUrl : 'https://snoopy.wigzopush.com/index.php?route=product/product&product_id=40',
110117
description: 'iPhone is a revolutionary new mobile phone that allows you',
111118
language: 'en'
119+
},
120+
page: {
121+
url: 'https://snoopy.wigzopush.com/index.php?route=product/product&product_id=40'
112122
}
113123
};
114124

@@ -118,12 +128,11 @@ describe('Wigzo', function() {
118128
price : productData.currency + ' ' + productData.price,
119129
category: productData.category,
120130
image : options.Wigzo.imageUrl,
121-
canonicalUrl : options.Wigzo.canonicalUrl,
131+
canonicalUrl : options.page.url,
122132
description: options.Wigzo.description,
123133
language: options.Wigzo.language
124134
};
125135

126-
127136
analytics.track('Product Clicked', productData, options);
128137
analytics.called(window.wigzo.index, wigzoProduct);
129138
});
@@ -141,9 +150,11 @@ describe('Wigzo', function() {
141150
var options = {
142151
Wigzo: { // make sure this is capitalized
143152
imageUrl : 'https://snoopy.wigzopush.com/image/cache/catalog/demo/iphone_1-228x228.jpg',
144-
canonicalUrl : 'https://snoopy.wigzopush.com/index.php?route=product/product&product_id=40',
145153
description: 'iPhone is a revolutionary new mobile phone that allows you',
146154
language: 'en'
155+
},
156+
page: {
157+
url: 'https://snoopy.wigzopush.com/index.php?route=product/product&product_id=40'
147158
}
148159
};
149160

@@ -153,7 +164,7 @@ describe('Wigzo', function() {
153164
price : productData.currency + ' ' + productData.price,
154165
category: productData.category,
155166
image : options.Wigzo.imageUrl,
156-
canonicalUrl : options.Wigzo.canonicalUrl,
167+
canonicalUrl : options.page.url,
157168
description: options.Wigzo.description,
158169
language: options.Wigzo.language
159170
};

0 commit comments

Comments
 (0)