Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.125
Choose a base ref
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.126
Choose a head ref
  • 15 commits
  • 25 files changed
  • 2 contributors

Commits on Mar 27, 2021

  1. Suppress match_wildcard_for_single_variants clippy false positive

    rust-lang/rust-clippy#6984
    
        error: wildcard matches only a single variant and will also match any future added variants
            --> serde_derive/src/internals/attr.rs:1918:9
             |
        1918 |         _ => {}
             |         ^ help: try this: `syn::Type::__TestExhaustive(_)`
             |
        note: the lint level is defined here
            --> serde_derive/src/lib.rs:18:22
             |
        18   | #![deny(clippy::all, clippy::pedantic)]
             |                      ^^^^^^^^^^^^^^^^
             = note: `#[deny(clippy::match_wildcard_for_single_variants)]` implied by `#[deny(clippy::pedantic)]`
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants
    
        error: wildcard matches only a single variant and will also match any future added variants
           --> serde_derive/src/internals/receiver.rs:153:13
            |
        153 |             _ => {}
            |             ^ help: try this: `Type::__TestExhaustive(_)`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants
    
        error: wildcard matches only a single variant and will also match any future added variants
           --> serde_derive/src/bound.rs:190:17
            |
        190 |                 _ => {}
            |                 ^ help: try this: `syn::Type::__TestExhaustive(_)`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants
    dtolnay committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    ce0844b View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Ignore poor suggestion from branches_sharing_code lint

    rust-lang/rust-clippy#7054
    
        error: all if blocks contain the same code at the end
            --> serde_derive/src/de.rs:2160:5
             |
        2160 | /         &fallthrough_arm_tokens
        2161 | |     };
             | |_____^
             |
        note: the lint level is defined here
            --> serde_derive/src/lib.rs:18:9
             |
        18   | #![deny(clippy::all, clippy::pedantic)]
             |         ^^^^^^^^^^^
             = note: `#[deny(clippy::branches_sharing_code)]` implied by `#[deny(clippy::all)]`
             = note: The end suggestion probably needs some adjustments to use the expression result correctly
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#branches_sharing_code
        help: consider moving the end statements out like this
             |
        2160 |     }
        2161 |     &fallthrough_arm_tokens;
             |
    dtolnay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    6c3bf7a View commit details
    Browse the repository at this point in the history
  2. Resolve safe_packed_borrows lint renamed to unaligned_references

        warning: lint `safe_packed_borrows` has been renamed to `unaligned_references`
            --> test_suite/tests/test_macros.rs:1926:8
             |
        1926 | #[deny(safe_packed_borrows)]
             |        ^^^^^^^^^^^^^^^^^^^ help: use the new name: `unaligned_references`
             |
             = note: `#[warn(renamed_and_removed_lints)]` on by default
    dtolnay committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    b53ebef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc4c31e View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2015 from dtolnay/symlink

    Build using relative path in repo if Windows lost the symlink
    dtolnay authored Apr 9, 2021
    Configuration menu
    Copy the full SHA
    47015a2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7aa4950 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Configuration menu
    Copy the full SHA
    c17c4ee View commit details
    Browse the repository at this point in the history
  2. Remove non_ascii_idents feature gate from test suite

        error: the feature `non_ascii_idents` has been stable since 1.53.0 and no longer requires an attribute to enable
         --> test_suite/tests/test_gen.rs:6:43
          |
        6 | #![cfg_attr(feature = "unstable", feature(non_ascii_idents))]
          |                                           ^^^^^^^^^^^^^^^^
          |
        note: the lint level is defined here
         --> test_suite/tests/test_gen.rs:5:9
          |
        5 | #![deny(warnings)]
          |         ^^^^^^^^
          = note: `#[deny(stable_features)]` implied by `#[deny(warnings)]`
    dtolnay committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2ebc771 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2018 from dtolnay/nonascii

    Remove non_ascii_idents feature gate from test suite
    dtolnay authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2ea132b View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2021

  1. Resolve flat_map_option pedantic clippy lint

        error: used `flat_map` where `filter_map` could be used instead
          --> serde_derive/src/bound.rs:52:10
           |
        52 |         .flat_map(|field| from_field(&field.attrs))
           |          ^^^^^^^^ help: try: `filter_map`
           |
        note: the lint level is defined here
          --> serde_derive/src/lib.rs:18:22
           |
        18 | #![deny(clippy::all, clippy::pedantic)]
           |                      ^^^^^^^^^^^^^^^^
           = note: `#[deny(clippy::flat_map_option)]` implied by `#[deny(clippy::pedantic)]`
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#flat_map_option
    
        error: used `flat_map` where `filter_map` could be used instead
          --> serde_derive/src/bound.rs:74:10
           |
        74 |         .flat_map(|variant| from_variant(&variant.attrs))
           |          ^^^^^^^^ help: try: `filter_map`
           |
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#flat_map_option
    dtolnay committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    1093f7e View commit details
    Browse the repository at this point in the history
  2. Remove suppression of removed clippy lint

        warning: lint `clippy::filter_map` has been removed: this lint has been replaced by `manual_filter_map`, a more specific lint
          --> serde_derive/src/lib.rs:42:5
           |
        42 |     clippy::filter_map,
           |     ^^^^^^^^^^^^^^^^^^
           |
           = note: `#[warn(renamed_and_removed_lints)]` on by default
    
        warning: lint `clippy::filter_map` has been removed: this lint has been replaced by `manual_filter_map`, a more specific lint
          --> serde_derive/src/lib.rs:42:5
           |
        42 |     clippy::filter_map,
           |     ^^^^^^^^^^^^^^^^^^
    dtolnay committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    1120e5a View commit details
    Browse the repository at this point in the history
  3. Ignore clone_instead_of_copied pedantic clippy lint

    Iterator::copied was introduced in Rust 1.35, whereas serde_test
    currently supports a minimum compiler version of 1.13.
    
        error: used `cloned` where `copied` could be used instead
           --> serde_test/src/de.rs:49:29
            |
        49  |         self.tokens.first().cloned()
            |                             ^^^^^^ help: try: `copied`
            |
        note: the lint level is defined here
           --> serde_test/src/lib.rs:149:52
            |
        149 | #![cfg_attr(feature = "cargo-clippy", deny(clippy, clippy_pedantic))]
            |                                                    ^^^^^^^^^^^^^^^
            = note: `#[deny(clippy::cloned_instead_of_copied)]` implied by `#[deny(clippy::pedantic)]`
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied
    dtolnay committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    6366f17 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Allow only unused_extern_crates instead of the whole `rust_2018_idi…

    …oms` lint group in `serde_derive`-generated code
    hyd-dev committed May 12, 2021
    Configuration menu
    Copy the full SHA
    dd29825 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2026 from hyd-dev/warning

    Allow only `unused_extern_crates` instead of the whole `rust_2018_idioms` lint group in `serde_derive`-generated code
    dtolnay authored May 12, 2021
    Configuration menu
    Copy the full SHA
    699bf3a View commit details
    Browse the repository at this point in the history
  3. Release 1.0.126

    dtolnay committed May 12, 2021
    Configuration menu
    Copy the full SHA
    d9c338e View commit details
    Browse the repository at this point in the history
Loading