Skip to content

Commit 027abc1

Browse files
committed
fixed node messaging example
1 parent 037dca0 commit 027abc1

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

pact/pact-node-messages/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"description": "",
55
"main": "index.js",
66
"scripts": {
7-
"test:consumer": "mocha src/consumer/*.spec.js",
8-
"test:provider": "mocha src/provider/*.spec.js",
7+
"test:pact:consumer": "mocha src/consumer/*.spec.js --exit",
8+
"test:pact:provider": "mocha src/provider/*.spec.js --exit",
99
"publish:pact": "node pact/publish.js"
1010
},
1111
"author": "Tom Hombergs",

pact/pact-node-messages/src/consumer/hero-event-handler.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ describe("message consumer", () => {
2727
"content-type": "application/json",
2828
})
2929
.verify(synchronousBodyHandler(handleHeroCreatedEvent))
30-
.then(done, (error) => done(error));
31-
});
30+
.then(() => done(), (error) => done(error));
31+
}).timeout(5000);
3232

3333
});
3434

pact/pact-node-messages/src/provider/hero-event-producer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
const HeroCreatedMessage = require('../common/hero-created-message');
22

3-
function produceHeroCreatedEvent(id) {
3+
function produceHeroCreatedEvent() {
44
return new Promise((resolve, reject) => {
5-
resolve({foo: "this is an invalid message that does not match the contract!"});
5+
resolve(new HeroCreatedMessage("Superman", "Flying", "DC", 42));
66
});
77
}
88

pact/pact-node-messages/src/provider/hero-event-producer.spec.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,21 @@ describe("message producer", () => {
66

77
const messagePact = new MessageProviderPact({
88
messageProviders: {
9-
"a hero created message": () => produceHeroCreatedEvent(42),
9+
"a hero created message": () => produceHeroCreatedEvent(),
1010
},
11-
log: path.resolve(process.cwd(), "logs"),
12-
logLevel: "debug",
11+
log: path.resolve(process.cwd(), "logs", "pact.log"),
12+
logLevel: "info",
1313
provider: "node-message-provider",
1414

1515
pactUrls: [path.resolve(process.cwd(), "pacts", "node-message-consumer-node-message-provider.json")],
1616

17+
// Pact seems not to load a pact file from a pact broker, so we have to make do with the local pact file
18+
// see https://github.com/pact-foundation/pact-js/issues/248
1719
// pactBrokerUrl: "https://adesso.pact.dius.com.au",
1820
// pactBrokerUsername: process.env.PACT_USERNAME,
1921
// pactBrokerPassword: process.env.PACT_PASSWORD,
20-
publishVerificationResult: true,
21-
providerVersion: '1.0.0',
22+
// publishVerificationResult: true,
23+
// providerVersion: '1.0.0',
2224
tags: ['latest']
2325
});
2426

@@ -28,7 +30,7 @@ describe("message producer", () => {
2830
it("should create a valid hero created message", (done) => {
2931
messagePact
3032
.verify()
31-
.then(done, (error) => done(error));
33+
.then(() => done(), (error) => done(error));
3234
}).timeout(5000);
3335

3436
});

0 commit comments

Comments
 (0)