Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hyperoslo/Lightbox
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: shortwave/Lightbox
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 5 files changed
  • 2 contributors

Commits on Feb 10, 2022

  1. Add flag to disable animated dismissals

    @rockwotj
    rockwotj committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    542c2ba View commit details
    Browse the repository at this point in the history

  2. Fix var

    @rockwotj
    rockwotj authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    74e6b4c View commit details
    Browse the repository at this point in the history

  3. Okay just disable swipe down entirely

    @rockwotj
    rockwotj authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    8bdd235 View commit details
    Browse the repository at this point in the history

  4. Update LightboxTransition.swift

    @rockwotj
    rockwotj authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    f655302 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Remove background from loading image. 

    It was off-center, so just removing it.
    @mikelehen
    mikelehen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1bea758 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge pull request #2 from shortwave/mikelehen/remove-loading-background 

    Remove background from loading image. It was off-center and ugly.
    @mikelehen
    mikelehen authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    20797f9 View commit details
    Browse the repository at this point in the history

  2. Add translucent background to header buttons to ensure they're visibl… 

    …e on light images. (#3)

* Fixes https://app.asana.com/0/1204781676683007/1206803553364508 (once we pull this into the Shortwave build).

Add a translucent background to the header buttons to ensure they're visible on light images.

Also adds haptics to close button.
    @mikelehen
    mikelehen authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    73c727b View commit details
    Browse the repository at this point in the history

  3. Add extra padding when the status bar isn't hidden. (#4) 

    With the buttons having a background now, they were squished up next to the iOS status bar and looked kind of awkward. Ideally we'd hide the status bar while the lightbox is open, but that doesn't work in Shortwave because React Native is controlling the status bar. So I'm adding some padding to make them look better.
    @mikelehen
    mikelehen authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8ceb9e5 View commit details
    Browse the repository at this point in the history
Loading