Use ZEND_LONG_FMT and avoid typecast in hMset (phpredis#1770)

michael-grunder · web-flow · commit 5bf881244dd3 · 2020-05-31T22:36:36.000-07:00
See phpredis#1764
diff --git a/redis_commands.c b/redis_commands.c
@@ -1684,7 +1684,7 @@ int redis_hmset_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
             mem_len = ZSTR_LEN(zkey);
             mem = ZSTR_VAL(zkey);
         } else {
-            mem_len = snprintf(kbuf, sizeof(kbuf), "%ld", (long)idx);
+            mem_len = snprintf(kbuf, sizeof(kbuf), ZEND_LONG_FMT, idx);
             mem = (char*)kbuf;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1684,7 +1684,7 @@ int redis_hmset_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,`
`1684`	`1684`	`mem_len = ZSTR_LEN(zkey);`
`1685`	`1685`	`mem = ZSTR_VAL(zkey);`
`1686`	`1686`	`} else {`
`1687`		`- mem_len = snprintf(kbuf, sizeof(kbuf), "%ld", (long)idx);`
	`1687`	`+ mem_len = snprintf(kbuf, sizeof(kbuf), ZEND_LONG_FMT, idx);`
`1688`	`1688`	`mem = (char*)kbuf;`
`1689`	`1689`	`}`
`1690`	`1690`