Skip to content

Commit 6f60a85

Browse files
kjlubickSkia Commit-Bot
authored andcommitted
Fix matrix scoping issue in sample
Change-Id: Id0023a12a21957ec9236d4ffaa03134995388d60 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278456 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
1 parent 59e7496 commit 6f60a85

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

docs/examples/GradientShader_MakeLinear.cpp

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ void draw(SkCanvas* canvas) {
1919
SkScalar positions[] = { 0.0, 0.65, 1.0 };
2020

2121
for (int i = 0; i < 4; i++) {
22-
SkScalar blockX = (i / 2) * 100;
23-
SkScalar blockY = (i % 2) * 100;
22+
SkScalar blockX = (i % 2) * 100;
23+
SkScalar blockY = (i / 2) * 100;
2424
SkPoint pts[] = { {blockX, blockY}, {blockX + 50, blockY + 100} };
2525

2626
int flags = 0; // interpolate colors in unpremul
@@ -29,17 +29,15 @@ void draw(SkCanvas* canvas) {
2929
flags = SkGradientShader::Flags::kInterpolateColorsInPremul_Flag;
3030
}
3131

32-
SkMatrix* matr = nullptr;
32+
SkMatrix matr = SkMatrix::I();
3333
if (i / 2 == 1) {
3434
// bottom row will be rotated 45 degrees.
35-
SkMatrix m;
36-
m.setRotate(45, blockX, blockY);
37-
matr = &m;
35+
matr.setRotate(45, blockX, blockY);
3836
}
3937

4038
auto lgs = SkGradientShader::MakeLinear(
41-
pts, colors, positions, 3, SkTileMode::kMirror,
42-
flags, matr);
39+
pts, colors, positions, 3, SkTileMode::kMirror,
40+
flags, &matr);
4341

4442
p.setShader(lgs);
4543
auto r = SkRect::MakeLTRB(blockX, blockY, blockX + 100, blockY + 100);

0 commit comments

Comments
 (0)