Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.2.1
Choose a base ref
...
head repository: socketio/engine.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.4.0
Choose a head ref
  • 20 commits
  • 29 files changed
  • 3 contributors

Commits on Nov 20, 2022

  1. Configuration menu
    Copy the full SHA
    d7bd2b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. docs: add note about socket.id

    Related: #644
    darrachequesne committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    3d28229 View commit details
    Browse the repository at this point in the history
  2. refactor: add types to socket.send()

    Related: #645
    darrachequesne committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    6d87a40 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Configuration menu
    Copy the full SHA
    bd74e7c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da45d84 View commit details
    Browse the repository at this point in the history
  3. chore(deps): bump engine.io from 4.1.2 to 6.2.1 in /examples/latency (#…

    …663)
    
    Bumps [engine.io](https://github.com/socketio/engine.io) from 4.1.2 to 6.2.1.
    - [Release notes](https://github.com/socketio/engine.io/releases)
    - [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md)
    - [Commits](4.1.2...6.2.1)
    
    ---
    updated-dependencies:
    - dependency-name: engine.io
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8f8b217 View commit details
    Browse the repository at this point in the history
  4. chore(deps): bump qs from 6.9.4 to 6.11.0 (#664)

    Bumps [qs](https://github.com/ljharb/qs) from 6.9.4 to 6.11.0.
    - [Release notes](https://github.com/ljharb/qs/releases)
    - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
    - [Commits](ljharb/qs@v6.9.4...v6.11.0)
    
    ---
    updated-dependencies:
    - dependency-name: qs
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Dec 14, 2022
    Configuration menu
    Copy the full SHA
    719e275 View commit details
    Browse the repository at this point in the history
  5. chore(deps): bump qs and express in /examples/latency (#665)

    Bumps [qs](https://github.com/ljharb/qs) to 6.11.0 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.
    
    
    Updates `qs` from 6.7.0 to 6.11.0
    - [Release notes](https://github.com/ljharb/qs/releases)
    - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
    - [Commits](ljharb/qs@v6.7.0...v6.11.0)
    
    Updates `express` from 4.17.1 to 4.18.2
    - [Release notes](https://github.com/expressjs/express/releases)
    - [Changelog](https://github.com/expressjs/express/blob/master/History.md)
    - [Commits](expressjs/express@4.17.1...4.18.2)
    
    ---
    updated-dependencies:
    - dependency-name: qs
      dependency-type: indirect
    - dependency-name: express
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8a937a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. perf: add the wsPreEncodedFrame option

    This optimization is only applied if:
    
    - the permessage-deflate extension is disabled (which is the default)
    - the "ws" package is used (which is the default)
    
    In that case, the WebSocket frame will only be computed once, when
    broadcasting to multiple clients.
    
    Related: socketio/socket.io-adapter@5f7b47d
    darrachequesne committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    5e34722 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. feat: add the "addTrailingSlash" option (#655)

    The "addTrailingSlash" option allows to control whether a trailing
    slash is added to the path of the HTTP requests:
    
    - true (default): "/engine.io/"
    - false: "/engine.io"
    
    Related: socketio/engine.io-client@21a6e12
    
    Signed-off-by: iifawzi <[email protected]>
    iifawzi authored and darrachequesne committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    d0fd474 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    33dc073 View commit details
    Browse the repository at this point in the history
  3. refactor: bump prettier to version 2.8.1

    This major bump creates a lot of noise, but it is necessary for
    prettier to be able to parse new syntax such as:
    
    - typed imports: `import { type xxx } from ...`
    - private attributes: `class A { #b; #c() {} }`
    darrachequesne committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    bc98bf1 View commit details
    Browse the repository at this point in the history
  4. fix: fix the ES module wrapper

    The package does not have a default export, so importing it from a
    project using ES modules would break in some cases.
    
    > Cannot destructure property 'Server' of '_engineIo.default'
    
    Related: #657
    darrachequesne committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    ed87609 View commit details
    Browse the repository at this point in the history
  5. fix: wait for all packets to be sent before closing the WebSocket con…

    …nection
    
    This reverts commit [1], which was included in `[email protected]` and
    `[email protected]`.
    
    The WebSocket connection was closed before all packets were written
    out, so for example when calling `socket.disconnect(true)` on the
    Socket.IO server (which disconnect from all namespaces and close the
    connection), the client would receive only the first disconnect packet
    and kept trying to reconnect to the other namespaces.
    
    The only difference with the previous implementation (pre 5.1.0) is
    that the "drain" event gets only called once at the end, and not after
    each packet.
    
    [1]: ad5306a
    
    Related: #648
    darrachequesne committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    a65a047 View commit details
    Browse the repository at this point in the history
  6. chore(release): 6.3.0

    darrachequesne committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    ae1ea77 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. refactor: make the compress option optional

    The compress option was inadvertently made mandatory in [1].
    
    [1]: 6d87a40
    darrachequesne committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    69603b9 View commit details
    Browse the repository at this point in the history
  2. chore(release): 6.3.1

    darrachequesne committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4d6f454 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. feat: add support for Express middlewares

    This commit implements middlewares at the Engine.IO level, because
    Socket.IO middlewares are meant for namespace authorization and are not
    executed during a classic HTTP request/response cycle.
    
    A workaround was possible by using the allowRequest option and the
    "headers" event, but this feels way cleaner and works with upgrade
    requests too.
    
    Syntax:
    
    ```js
    engine.use((req, res, next) => {
      // do something
    
      next();
    });
    
    // with express-session
    import session from "express-session";
    
    engine.use(session({
      secret: "keyboard cat",
      resave: false,
      saveUninitialized: true,
      cookie: { secure: true }
    });
    
    // with helmet
    import helmet from "helmet";
    
    engine.use(helmet());
    ```
    
    Related:
    
    - #668
    - #651
    - socketio/socket.io#4609
    - socketio/socket.io#3933
    - a lot of other issues asking for compatibility with express-session
    darrachequesne committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    24786e7 View commit details
    Browse the repository at this point in the history
  2. chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (#667)

    Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
    - [Release notes](https://github.com/bmeck/node-cookiejar/releases)
    - [Commits](https://github.com/bmeck/node-cookiejar/commits)
    
    ---
    updated-dependencies:
    - dependency-name: cookiejar
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    6220d14 View commit details
    Browse the repository at this point in the history
  3. chore(release): 6.4.0

    darrachequesne committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    898bd1c View commit details
    Browse the repository at this point in the history
Loading