Added sweet error message when trying to use flashsocket without root privileges (thanks @wink for inspiration)

Removed clients/clientsIndex and only using the index (fixes #28)

Author: rauchg

lib/socket.io/listener.js

@@ -35,8 +35,8 @@ Listener = module.exports = function(server, options){
 			require('sys').log(message);
 		}
 	}, options);
-	this.clients = [];
-	this.clientsIndex = {};
+
+	this.clients = {};
 
 	var listeners = this.server.listeners('request');
 	this.server.removeAllListeners('request');
@@ -65,9 +65,9 @@ sys.inherits(Listener, process.EventEmitter);
 for (var i in options) Listener.prototype[i] = options[i];
 
 Listener.prototype.broadcast = function(message, except){
-	for (var i = 0, l = this.clients.length; i < l; i++){
-		if (this.clients[i] && (!except || [].concat(except).indexOf(this.clients[i].sessionId) == -1)){
-			this.clients[i].send(message);
+	for (var i = 0, k = Object.keys(this.clients), l = k.length; i < l; i++){
+		if (this.clients[k[i]] && (!except || [].concat(except).indexOf(this.clients[k[i]].sessionId) == -1)){
+			this.clients[k[i]].send(message);
 		}
 	}
 	return this;
@@ -79,7 +79,7 @@ Listener.prototype.check = function(req, res, httpUpgrade, head){
 		parts = path.substr(1).split('/');
 		if (!(parts[1] in transports)) return false;
 		if (parts[2]){
-			cn = this._lookupClient(parts[2]);
+			cn = this.clients[parts[2]];
 			if (cn){
 				cn._onConnect(req, res);
 			} else {
@@ -94,17 +94,11 @@ Listener.prototype.check = function(req, res, httpUpgrade, head){
 	return false;
 };
 
-Listener.prototype._lookupClient = function(sid){
-	return this.clientsIndex[sid];
-};
-
 Listener.prototype._onClientConnect = function(client){
 	if (!(client instanceof Client) || !client.sessionId){
 		return this.options.log('Invalid client');
 	}
-	client.i = this.clients.length;
-	this.clients.push(client);
-	this.clientsIndex[client.sessionId] = client;
+	this.clients[client.sessionId] = client;
 	this.options.log('Client '+ client.sessionId +' connected');
 	this.emit('clientConnect', client);
 	this.emit('connection', client);
@@ -115,8 +109,7 @@ Listener.prototype._onClientMessage = function(data, client){
 };
 
 Listener.prototype._onClientDisconnect = function(client){
-	this.clientsIndex[client.sessionId] = null;
-	this.clients[client.i] = null;
+	delete this.clients[client.sessionId];
 	this.options.log('Client '+ client.sessionId +' disconnected');
 	this.emit('clientDisconnect', client);
 };

lib/socket.io/transports/flashsocket.js

@@ -36,4 +36,23 @@ try {
 		socket.write('</cross-domain-policy>\n');
 		socket.end();	
 	}).listen(843);
-} catch(e){}
+} catch(e){
+	if (e.errno == 13){
+		console.error("\x1B[1;31m" + [
+			'================================================',
+		  '|               WARNING! DANGER!               |',
+		  '|                                              |',
+		  '| The flash websocket transport will not work  |', 
+		  '| unless you run your node instance with root  |',
+		  '| privileges.                                  |',
+		  '|                                              |',
+		  '| A flash XML policy file has to be served on  |',
+		  '| port 843 (privileged) for it to work.        |',
+		  '|                                              |',
+		  '| You can run socket.io without this trasnport |',
+		  '| to make this message go (refer to README).   |',
+		  '|                                              |',
+		  '===============================================|'
+		].join("\n") + "\x1B[0m");
+	}
+}