Skip to content

Commit 253d781

Browse files
authored
chore: Remove orientation settings in BottomTabsTest (#3312)
## Description The `orientation` options set on BottomTabsTest's TabScreens get annoying when testing other scenarios. Let's maybe remove them, and if they are needed in one specific case, they can be added back for testing purposes without commiting. ## Changes Removed `orientation` settings from BottomTabsTest.
1 parent c56d64b commit 253d781

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

apps/src/tests/TestBottomTabs/index.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ const TAB_CONFIGS: TabConfiguration[] = [
116116
templateSource: require('../../../assets/variableIcons/icon_fill.png'),
117117
},
118118
title: 'Tab2',
119-
orientation: 'landscape',
120119
},
121120
component: Tab2,
122121
safeAreaConfiguration: {
@@ -159,7 +158,6 @@ const TAB_CONFIGS: TabConfiguration[] = [
159158
// systemItem: 'search', // iOS specific
160159
// systemItem: 'contacts', // iOS specific
161160
// systemItem: 'history', // iOS specific
162-
orientation: 'portrait',
163161
},
164162
component: Tab3,
165163
},
@@ -183,7 +181,6 @@ const TAB_CONFIGS: TabConfiguration[] = [
183181
title: 'Tab4',
184182
systemItem: 'search', // iOS specific
185183
badgeValue: '123',
186-
orientation: 'portrait',
187184
},
188185
component: Tab4,
189186
},

apps/src/tests/TestBottomTabs/tabs/Tab4.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,15 +113,12 @@ export function Tab4() {
113113
<Stack.Screen
114114
name="Screen1"
115115
component={Screen1}
116-
options={{ headerTransparent: true, orientation: 'landscape' }}
116+
options={{ headerTransparent: true }}
117117
/>
118118
<Stack.Screen
119119
name="Screen2"
120120
component={Screen2}
121-
options={{
122-
headerLargeTitle: true,
123-
orientation: 'default',
124-
}}
121+
options={{ headerLargeTitle: true }}
125122
/>
126123
<Stack.Screen
127124
name="Screen3"

0 commit comments

Comments
 (0)