Skip to content

Enable bugprone-unchecked-optional-access clang-tidy check #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bavulapati wants to merge 8 commits into from
Closed

Enable bugprone-unchecked-optional-access clang-tidy check #1872

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
63c80f0
Enable bugprone-unchecked-optional-access clang-tidy check
bavulapati Jul 22, 2025
e7a95d7
Merge main
bavulapati Jul 27, 2025
ebbfd7d
ignore linting error
bavulapati Jul 27, 2025
095e7af
Fix merge lost enablement
bavulapati Jul 27, 2025
cddc181
Merge branch 'main' into enable-bugprone-unchecked-optional-access
bavulapati Jul 27, 2025
46b694b
fix errors reported on CI
bavulapati Jul 27, 2025
bf60ec4
fix clang-tidy issues reported on CI
bavulapati Jul 27, 2025
1695289
Merge branch 'main' into enable-bugprone-unchecked-optional-access
bavulapati Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix errors reported on CI 
Signed-off-by: Balakrishna Avulapati <[email protected]>
  • Loading branch information
@bavulapati
bavulapati committed Jul 27, 2025
commit 46b694b5b05c67e0b0126d43ed6fdd4d95d5e11a
2 changes: 2 additions & 0 deletions src/core/jsonschema/jsonschema.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,7 @@ auto sourcemeta::core::reference_visit(
assert(property.second.is_string());
assert(walker_result.vocabulary.has_value());
sourcemeta::core::URI reference{property.second.to_string()};
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
callback(subschema, base, walker_result.vocabulary.value(),
property.first, reference);
}
Expand Down Expand Up @@ -685,6 +686,7 @@ auto sourcemeta::core::unidentify(
}

assert(entry.base_dialect.has_value());
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
sourcemeta::core::anonymize(subschema, entry.base_dialect.value());

if (entry.vocabularies.contains(
Expand Down
Loading