Adding unit tests to improve code converage test

Author: ddurham2

connexion/operations/openapi.py

@@ -313,7 +313,7 @@ def _get_body_argument(self, body, arguments, has_kwargs, sanitize):
         # could have individual arguments to receive all the body's parameters, or
         # they may have a **kwargs, arguments to receive anything.  So, the question
         # arises that if kwargs is given, do we pass to the handler a single body
-        # argument, or the broken out arguments, or both.
+        # argument, or the broken out arguments, or both?
         #
         # #1 If 'x-body-arg' is explicitly given and it exists in [arguments], then the
         # body, as a whole, will be passed to the handler with that name. STOP.

tests/api/test_parameters.py

@@ -352,6 +352,9 @@ def test_nullable_parameter(simple_app):
     resp = app_client.put('/v1.0/nullable-parameters', data="None", headers=headers)
     assert json.loads(resp.data.decode('utf-8', 'replace')) == 'it was None'
 
+    resp = app_client.put('/v1.0/nullable-parameters-noargs', data="None", headers=headers)
+    assert json.loads(resp.data.decode('utf-8', 'replace')) == 'hello'
+
 
 def test_args_kwargs(simple_app):
     app_client = simple_app.app.test_client()
@@ -363,6 +366,16 @@ def test_args_kwargs(simple_app):
     assert resp.status_code == 200
     assert json.loads(resp.data.decode('utf-8', 'replace')) == {'foo': 'a'}
 
+    if simple_app._spec_file == 'openapi.yaml':
+        body = { 'foo': 'a', 'bar': 'b' }
+        resp = app_client.post(
+            '/v1.0/body-params-as-kwargs',
+            data=json.dumps(body),
+            headers={'Content-Type': 'application/json'})
+        assert resp.status_code == 200
+        # having only kwargs and no explicit x-body-name, the handler would have been passed 'body' and the individual params from body
+        assert json.loads(resp.data.decode('utf-8', 'replace')) == {'body': {'foo': 'a', 'bar': 'b'}, 'foo': 'a', 'bar': 'b'}
+
 
 def test_param_sanitization(simple_app):
     app_client = simple_app.app.test_client()

tests/fakeapi/hello.py

@@ -403,6 +403,9 @@ def test_nullable_param_put(contents):
         return 'it was None'
     return contents
 
+def test_nullable_param_put_noargs(dummy=''):
+    return 'hello'
+
 
 def test_custom_json_response():
     return {'theResult': DummyClass()}, 200
@@ -460,6 +463,9 @@ def optional_auth(**kwargs):
 def test_args_kwargs(*args, **kwargs):
     return kwargs
 
+def test_args_kwargs_post(*args, **kwargs):
+    return kwargs
+
 
 def test_param_sanitization(query=None, form=None):
     result = {}

tests/fixtures/simple/openapi.yaml

@@ -842,6 +842,24 @@ paths:
       responses:
         '200':
           description: OK
+  /nullable-parameters-noargs:
+    put:
+      operationId: fakeapi.hello.test_nullable_param_put_noargs
+      responses:
+        '200':
+          description: OK
+      requestBody:
+        content:
+          application/json:
+            schema:
+              nullable: true
+              x-body-name: contents
+              type: object
+              properties:
+                name:
+                  type: string
+        description: Just a testing parameter.
+        required: true
   /custom-json-response:
     get:
       operationId: fakeapi.hello.test_custom_json_response
@@ -893,6 +911,25 @@ paths:
             application/json:
               schema:
                 type: object
+  /body-params-as-kwargs:
+    post:
+      operationId: fakeapi.hello.test_args_kwargs_post
+      requestBody:
+        content:
+          application/json:
+            schema:
+              type: object
+              properties:
+                foo:
+                  type: string
+              additionalProperties: true
+      responses:
+        '200':
+          description: Return kwargs
+          content:
+            application/json:
+              schema:
+                type: object
   /text-request:
     post:
       operationId: fakeapi.hello.get_data_as_text

tests/fixtures/simple/swagger.yaml

@@ -692,6 +692,26 @@ paths:
         200:
           description: OK
 
+  /nullable-parameters-noargs:
+    put:
+      operationId: fakeapi.hello.test_nullable_param_put_noargs
+      produces:
+        - application/json
+      parameters:
+        - name: contents
+          description: Just a testing parameter.
+          in: body
+          x-nullable: true
+          required: true
+          schema:
+              type: object
+              properties:
+                name:
+                  type: string
+      responses:
+        200:
+          description: OK
+
   /custom-json-response:
     get:
       operationId: fakeapi.hello.test_custom_json_response
@@ -746,6 +766,30 @@ paths:
           schema:
             type: object
 
+  /body-params-as-kwargs:
+    post:
+      operationId: fakeapi.hello.test_args_kwargs_post
+      produces:
+        - application/json
+      parameters:
+        - name: $body
+          description: Just a testing parameter in the body
+          in: body
+          required: true
+          schema:
+            type: object
+            properties:
+              foo:
+                type: string
+              bar:
+                type: string
+            additionalProperties: true
+      responses:
+        200:
+          description: Return kwargs
+          schema:
+            type: object
+
   /text-request:
     post:
       operationId: fakeapi.hello.get_data_as_text