Rework security handler factory into sync and async #1495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
force-pushed
the
feature/sync-async-security
branch
from
a05f99a to
f448d53
Compare
RobbeSneyders
force-pushed
the
feature/connexion-middleware
branch
from
e9b4dd7 to
977a691
Compare
RobbeSneyders
force-pushed
the
feature/sync-async-security
branch
from
d286806 to
7b3f883
Compare
RobbeSneyders
commented
Mar 18, 2022
RobbeSneyders
force-pushed
the
feature/connexion-middleware
branch
from
800b8ae to
fe03909
Compare
Base automatically changed from
feature/connexion-middleware
to
feature/python3.10
March 24, 2022 21:51
RobbeSneyders
force-pushed
the
feature/python3.10
branch
from
fe03909 to
fc10145
Compare
Member
Author
|
Closing this PR as some of the changes are irrelevant after moving security into the middleware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #1491 which removed the
aiohttp_security_handler_factory.flask_security_handler_factoryis actually not Flask specific, so we can refactor this into a generic sync and async class. I also lifted some methods out of the abstract class since they were overwritten in 1 of 2 subclasses.