rm Fermyon from template output and examples #3034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
approved these changes
Mar 2, 2025
fibonacci1729
approved these changes
Mar 2, 2025
rylev
approved these changes
Mar 3, 2025
| date: Sun, 02 Mar 2025 20:09:11 GMT | ||
|
|
||
| Hello, Fermyon | ||
| Hello World! |
Collaborator
There was a problem hiding this comment.
Nit: Hello, Spin! might be better?
Collaborator
|
@michelleN Looks like this might need your DCO signoff? |
Signed-off-by: Michelle Dhanani <[email protected]>
michelleN
force-pushed
the
updatetemplates
branch
from
20602cc to
a7b1a38
Compare
Collaborator
|
I think the CI failures are our traditional "things that have been updated to reflect new templates failing because they are getting templates from main rather than from the branch" motif. Gonna bypass and merge and let the chips fall where they may |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.