Fix concurrent HTTP component downloads race condition #3050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <[email protected]>
fibonacci1729
approved these changes
Mar 18, 2025
Collaborator
fibonacci1729
left a comment
fibonacci1729
left a comment
There was a problem hiding this comment.
Looks sane to me! It's worth getting this in asap to unblock you.
michelleN
approved these changes
Mar 18, 2025
Collaborator
michelleN
left a comment
michelleN
left a comment
There was a problem hiding this comment.
Would be great to have an e2e sometime down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3048.
I don't love this, to be honest. I want
verified_downloadnot to rely on the assumption that same file name guarantees same file contents, but maybe the cost in weird types (a single case enum, fie) and apologetically long doc comments is hinting to me that you can't always get what you want.Anyway, it appears to work. But if someone would care to gently point out to me the obviously more elegant fix that I've overlooked, I'll be delighted to implement it.