Release 2.2.4

Author: Shakeel Mohamed

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Splunk SDK for C# PCL
 
+## Version 2.2.4
+
+### Bug Fixes
+
+* Handle empty strings in Atom entry responses from the REST API. GitHub pull request #60.
+
 ## Version 2.2.3
 
 ### New features and APIs

README.md

@@ -1,5 +1,5 @@
 # Splunk SDK for C# 
-## Version 2.2.3
+## Version 2.2.4
 
 > **Note:** For the most up to date documentation for the Splunk SDK for C#, 
 > see http://dev.splunk.com/csharp.

src/Splunk.Client.Helpers/Properties/AssemblyInfo.cs

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("2.2.3.0")]
-[assembly: AssemblyFileVersion("2.2.3.0")]
+[assembly: AssemblyVersion("2.2.4.0")]
+[assembly: AssemblyFileVersion("2.2.4.0")]

src/Splunk.Client/Properties/AssemblyInfo.cs

@@ -41,5 +41,5 @@
 
 //// Version information
 
-[assembly: AssemblyVersion("2.2.3.0")]
-[assembly: AssemblyFileVersion("2.2.3.0")]
+[assembly: AssemblyVersion("2.2.4.0")]
+[assembly: AssemblyFileVersion("2.2.4.0")]

src/Splunk.Client/Splunk/Client/AtomEntry.cs

@@ -389,6 +389,21 @@ static async Task<dynamic> ParseDictionaryAsync(XmlReader reader, int level)
                     string propertyName;
                     dynamic propertyValue;
 
+                    // There are cases where the server sends us bad values for "s:key", namely
+                    // the empty string. This happens for example when we get back the metadata for
+                    // a search job which contains an "eval". In these cases, we simply replace the
+                    // empty string with a literal string called "empty", so that we know where it came
+                    // from.
+                    //
+                    // The risk with this fix is that we will have multiple empty keys at the same 
+                    // level, and thus using "empty" would clash. However, this would be an even more
+                    // serious error on the part of the API, as it would mean we have no way to disambiguate
+                    // those two entries. As such, we feel it is safe.
+                    if (names[names.Length - 1] == "")
+                    {
+                        names[names.Length - 1] = "empty";
+                    }
+
                     for (int i = 0; i < names.Length - 1; i++)
                     {
                         propertyName = NormalizePropertyName(names[i]);

src/Splunk.Client/Splunk/Client/Context.cs

@@ -103,7 +103,7 @@ public Context(Scheme scheme, string host, int port, TimeSpan timeout, HttpMessa
             this.Host = host;
             this.Port = port;
             this.httpClient = handler == null ? new HttpClient(new HttpClientHandler { UseCookies = false }) : new HttpClient(handler, disposeHandler);
-            this.httpClient.DefaultRequestHeaders.Add("User-Agent", "splunk-sdk-csharp/2.2.3");
+            this.httpClient.DefaultRequestHeaders.Add("User-Agent", "splunk-sdk-csharp/2.2.4");
             this.CookieJar = new CookieStore();
 
             if (timeout != default(TimeSpan))

src/Splunk.ModularInputs/Properties/AssemblyInfo.cs

@@ -39,5 +39,5 @@
 
 //// Version information
 
-[assembly: AssemblyVersion("2.2.3.0")]
-[assembly: AssemblyFileVersion("2.2.3.0")]
+[assembly: AssemblyVersion("2.2.4.0")]
+[assembly: AssemblyFileVersion("2.2.4.0")]