-
Notifications
You must be signed in to change notification settings - Fork 537
services/galexie: Add replace (overwrite) command. #5826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sreuland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work and test coverage! left a few comments for consideration, nothing blocking.
tamirms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments for minor issues but, overall, this looks good!
a24c75e to
f1395e1
Compare
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add a new command
replaceto re-export of all ledgers within a specified range, overwriting any existing data in the data lake. It is restricted to bounded mode.Why
stellar/stellar-galexie#5
Known limitations
The command uses a single PutFile operation and does not check for the existence. So, the uploader cannot distinguish between a new file and an overwritten one. Therefore, for metrics logging label
already_existswill always be recorded as an empty string.