Skip to content

Commit 45b988d

Browse files
committed
v12.13.3.2: hotfix for DSA target condition
1 parent 208762f commit 45b988d

File tree

5 files changed

+14
-2
lines changed

5 files changed

+14
-2
lines changed

HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
.. :changelog:
22
33
Release History
4+
12.13.3.2(2019-07-04)
5+
+++++++++++++++++++++++++
6+
* Add Bulk entity mapping for the CustomLabel dynamic ad target condition.
7+
48
12.13.3.1(2019-07-02)
59
+++++++++++++++++++++++++
610
* Fix import issue introduced by version 12.13.3, where clients would observe error ModuleNotFoundError: No module named 'bingads.v13.bulk.entities.feeds'.

bingads/manifest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import sys
2-
VERSION = '12.13.3.1'
2+
VERSION = '12.13.3.2'
33
BULK_FORMAT_VERSION_5 = '5.0'
44
BULK_FORMAT_VERSION_6 = '6.0'
55
WORKING_NAME = 'BingAdsSDKPython'

bingads/v12/internal/extensions.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -765,6 +765,10 @@ def csv_to_entity_DSAWebpageParameter(row_values, entity):
765765
condition.Operand = WebpageConditionOperand.PageTitle
766766
elif webpage_condition.lower() == 'pagecontent':
767767
condition.Operand = WebpageConditionOperand.PageContent
768+
elif webpage_condition.lower() == 'customlabel':
769+
condition.Operand = WebpageConditionOperand.CustomLabel
770+
elif webpage_condition.lower() == 'unknown':
771+
condition.Operand = WebpageConditionOperand.Unknown
768772
else:
769773
# TODO wait bug 54825 to be fixed
770774
if webpage_condition.lower() == 'none':

bingads/v13/internal/extensions.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -803,6 +803,10 @@ def csv_to_entity_DSAWebpageParameter(row_values, entity):
803803
condition.Operand = WebpageConditionOperand.PageTitle
804804
elif webpage_condition.lower() == 'pagecontent':
805805
condition.Operand = WebpageConditionOperand.PageContent
806+
elif webpage_condition.lower() == 'customlabel':
807+
condition.Operand = WebpageConditionOperand.CustomLabel
808+
elif webpage_condition.lower() == 'unknown':
809+
condition.Operand = WebpageConditionOperand.Unknown
806810
else:
807811
# TODO wait bug 54825 to be fixed
808812
if webpage_condition.lower() == 'none':

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
except ImportError:
44
from distutils.core import setup
55

6-
VERSION = '12.13.3.1'
6+
VERSION = '12.13.3.2'
77

88
with open('README.rst', 'r') as f:
99
readme = f.read()

0 commit comments

Comments
 (0)