Skip to content

Commit d99e033

Browse files
committed
Merge branch 'add-remember-me-cookie-assertions' into main
2 parents 100dc0c + 2e6e5b0 commit d99e033

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

app/controllers/concerns/authentication.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,6 @@ def user_signed_in?
5858
end
5959

6060
def store_location
61-
session[:user_return_to] = request.original_url if request.get? && request.local?
61+
session[:user_return_to] = request.original_url if request.get?
6262
end
6363
end

test/controllers/sessions_controller_test.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,12 @@ class SessionsControllerTest < ActionDispatch::IntegrationTest
4444

4545
assert_not_nil current_user
4646
assert_not_nil cookies[:remember_token]
47+
48+
remember_me_cookie = cookies.get_cookie("remember_token")
49+
50+
assert remember_me_cookie.http_only?
51+
assert remember_me_cookie.secure?
52+
assert_equal "Strict", remember_me_cookie.to_h["SameSite"]
4753
end
4854

4955
test "should forget user when logging out" do

0 commit comments

Comments
 (0)