Skip to content

Fix display of large components #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2017
Merged

Fix display of large components #1237

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c757c8d
Fix display of large components
su-narthur Jun 9, 2017
6b2d596
Merge branch 'master' into patch-1
shilman Jun 10, 2017
8e89aa8
Merge branch 'master' into patch-1
ndelangen Jul 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion addons/centered/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,13 @@ const style = {
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
overflow: 'auto',
};

const innerStyle = {
margin: 'auto',
}

export default function(storyFn) {
return <div style={style}>{storyFn()}</div>;
return <div style={style}><div style={innerStyle}>{storyFn()}</div></div>;
Copy link
Member

@ndelangen ndelangen Jun 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding another container defeats the purpose of the centered addon, I'll have to test.

Copy link
Contributor Author

@su-narthur su-narthur Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this? I'd be happy to try to improve the fix if this proves to have problems.

Copy link
Member

@ndelangen ndelangen Jul 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this

}