Skip to content

Conversation

@syneva-runyan
Copy link
Contributor

@syneva-runyan syneva-runyan commented Nov 19, 2017

Issue: #2196

What I did

Fixed warning being outputting from unit tests.

@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #2343 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
+ Coverage    21.2%   21.23%   +0.03%     
==========================================
  Files         283      283              
  Lines        6155     6155              
  Branches      736      714      -22     
==========================================
+ Hits         1305     1307       +2     
- Misses       4271     4303      +32     
+ Partials      579      545      -34
Impacted Files Coverage Δ
lib/ui/src/modules/ui/components/layout/index.js 80.35% <ø> (ø) ⬆️
addons/info/src/components/markdown/text.js 77.77% <100%> (+11.11%) ⬆️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.04% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
addons/a11y/src/A11yManager.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 25.71% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 41.41% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fd5df...f7a5106. Read the comment docs.

return <div style={style}>{props.children}</div>;
}

P.defaultProps = defaultProps;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change the component name too? Looks like it's now called P, but renders a DIV.

Thanks to the comment we do know why though 👍 .

Copy link
Contributor Author

@syneva-runyan syneva-runyan Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it would make sense to change it, but in that case, do we go ahead and distinguish when the component is used as a wrapper and when it's just used as <p> tag? Or if not, what do we rename this to?

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@syneva-runyan can you do the same for release/3.3 branch after we merge this PR?

@syneva-runyan
Copy link
Contributor Author

@Hypnosphi sure.

@Hypnosphi Hypnosphi merged commit cad0dc2 into storybookjs:master Nov 21, 2017
@Hypnosphi
Copy link
Member

@syneva-runyan please uncomment those lines when making the PR for release/3.3: https://github.com/storybooks/storybook/blob/release/3.3/scripts/jest.init.js#L17-L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants