From 9c3aeb61df1621e52ccb13899914f6c531877e84 Mon Sep 17 00:00:00 2001 From: Gert Hengeveld Date: Mon, 23 Jun 2025 14:23:31 +0200 Subject: [PATCH 1/4] Add missing ARIA label --- code/core/src/components/components/Modal/Modal.styled.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/core/src/components/components/Modal/Modal.styled.tsx b/code/core/src/components/components/Modal/Modal.styled.tsx index f9e2fb8f7535..9ded17edd0e4 100644 --- a/code/core/src/components/components/Modal/Modal.styled.tsx +++ b/code/core/src/components/components/Modal/Modal.styled.tsx @@ -64,7 +64,7 @@ export const Container = styled.div<{ width?: number; height?: number }>( export const CloseButton = (props: React.ComponentProps) => ( - + From d0752028003e2582b642dfa9cb3cfd39926ff1a0 Mon Sep 17 00:00:00 2001 From: Gert Hengeveld Date: Mon, 23 Jun 2025 14:24:01 +0200 Subject: [PATCH 2/4] Prevent crashing browser when entry.children is undefined --- code/core/src/manager/utils/tree.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/core/src/manager/utils/tree.ts b/code/core/src/manager/utils/tree.ts index 15d104f214e9..2451dd6e16dd 100644 --- a/code/core/src/manager/utils/tree.ts +++ b/code/core/src/manager/utils/tree.ts @@ -40,7 +40,7 @@ export const getDescendantIds = memoize(1000)(( skipLeafs: boolean ): string[] => { const entry = data[id]; - const children = entry.type === 'story' || entry.type === 'docs' ? [] : entry.children; + const children = entry.type === 'story' || entry.type === 'docs' ? [] : entry.children || []; return children.reduce((acc, childId) => { const child = data[childId]; From d35a9b54cba1094ff843775055576d03dd344fb1 Mon Sep 17 00:00:00 2001 From: Gert Hengeveld Date: Wed, 25 Jun 2025 15:04:04 +0200 Subject: [PATCH 3/4] Add missing ARIA label --- code/core/src/manager/components/sidebar/Sidebar.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/code/core/src/manager/components/sidebar/Sidebar.tsx b/code/core/src/manager/components/sidebar/Sidebar.tsx index 38968173e0fd..605dd84dae78 100644 --- a/code/core/src/manager/components/sidebar/Sidebar.tsx +++ b/code/core/src/manager/components/sidebar/Sidebar.tsx @@ -176,6 +176,7 @@ export const Sidebar = React.memo(function Sidebar({ tooltip={} > { setIsFileSearchModalOpen(true); From af20e7e3365a41e74c02ff58eb3d88d708c03b08 Mon Sep 17 00:00:00 2001 From: Gert Hengeveld Date: Wed, 25 Jun 2025 16:07:20 +0200 Subject: [PATCH 4/4] Improve guard --- code/core/src/manager/utils/tree.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/code/core/src/manager/utils/tree.ts b/code/core/src/manager/utils/tree.ts index 2451dd6e16dd..49919271b43e 100644 --- a/code/core/src/manager/utils/tree.ts +++ b/code/core/src/manager/utils/tree.ts @@ -40,8 +40,10 @@ export const getDescendantIds = memoize(1000)(( skipLeafs: boolean ): string[] => { const entry = data[id]; - const children = entry.type === 'story' || entry.type === 'docs' ? [] : entry.children || []; - return children.reduce((acc, childId) => { + if (!entry || entry.type === 'story' || entry.type === 'docs' || !entry.children) { + return []; + } + return entry.children.reduce((acc, childId) => { const child = data[childId]; if (!child || (skipLeafs && (child.type === 'story' || child.type === 'docs'))) {